bugGNU Octave - Bugs: bug #51680, some LDFLAGS variables may be a...

 
 

bug #51680: some LDFLAGS variables may be a space instead of empty string, throwing off other tests

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Mon 07 Aug 2017 04:12:19 AM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Installation Failure
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Closed
Release: 4.2.1Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Aug 2017 03:31:08 PM UTC, comment #4:

Pushed on stable and merged to default

https://hg.savannah.gnu.org/hgweb/octave/rev/6ae0292aaa5c

Now retesting the complete build on 14.04.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 07 Aug 2017 03:27:02 PM UTC, comment #3:

I'm throwing a sed on the end of each pkg-config invocation, testing now. There may be ways to rely on shell string expansion, but sed is the safest and most portable.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 07 Aug 2017 03:16:34 PM UTC, comment #2:

Is there something magical in shell syntax that can filter spaces, or do you have to resort to sed or some such utility?

Rik <rik5>
Project Administrator
Mon 07 Aug 2017 03:09:56 PM UTC, comment #1:

Dug into the pkg-config history to determine that this only affects users with pkg-config < 0.28. This is basically Ubuntu 14.04 and older and CentOS 7 and older.

It's unfortunate but I think we should address this, so I'm going to push a change on stable that cleans up the output of pkg-config to ensure there are no empty strings that are actually space characters.

This should fix mysterious build problems I've been seeing where I need to install all the development libraries that Octave was built with in order to build a trivial oct file.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 07 Aug 2017 04:12:19 AM UTC, original submission:

On Ubuntu 14.04, I find that some pkg-config commands may return what appears to be an empty string, but is actually a space character. There are other tests in configure and possibly elsewhere in the code base that test for empty strings, for example

which is breaking the build configuration further down the line, for example the set of library dependencies that are encoded in mkoctfile.

I'm working on a workaround for this that I can apply as a patch to the 4.2.1 release, and will post again when I get something working.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Aug 2017 03:31:08 PM UTCmtmillerStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1