bugGNU nano - Bugs: bug #51674, current git compilation fails

 
 

bug #51674: current git compilation fails

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Sun 06 Aug 2017 08:23:42 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 06 Aug 2017 05:45:04 PM UTC, comment #1:

Yes, I ran into that problem too, on my old laptop, with Ubuntu 10.04. Strangely it is not an issue on 16.04, 12.04, nor 08.04.

Anyway, fixed in git, 67915f5d.

(I expext some more fallout from the BSDs, but we'll see that when the next release reaches them.)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sun 06 Aug 2017 08:23:42 AM UTC, original submission:

Current git, 884d410, refuses to compile on my Slackware 14.2 system. After a standard ./autogen.sh && ./configure && make, and with UTF-8 support autodetected by default, there's this warning and error:

nano.c: In function ‘main’:
nano.c:1990:9: warning: implicit declaration of function ‘setlocale’
[-Wimplicit-function-declaration]
if (setlocale(LC_ALL, "") != NULL &&
^
nano.c:1990:19: error: ‘LC_ALL’ undeclared (first use in this function)
if (setlocale(LC_ALL, "") != NULL &&
^
nano.c:1990:19: note: each undeclared identifier is reported only once for each
function it appears in
Makefile:1552: recipe for target 'nano.o' failed
make[2]: *** [nano.o] Error 1
make[2]: Leaving directory '/home/dramsey/software/Slackware/nano/git/nano/src'
Makefile:1530: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/dramsey/software/Slackware/nano/git/nano'
Makefile:1469: recipe for target 'all' failed
make: *** [all] Error 2

This appears to be caused by commit 80686bb. Readding

#include <locale.h>

to nano.c fixes the build for me, since setlocale() and LC_ALL are defined in locale.h.

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 06 Aug 2017 05:45:04 PM UTCbensStatusNone=>Fixed
      Assigned toNone=>bens
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1