bugGNU Octave - Bugs: bug #51647, Indices in toeplitz help should...

 
 

bug #51647: Indices in toeplitz help should start at 0

Submitted by:  A.R. Burgers <arb>
Submitted on:  Thu 03 Aug 2017 06:49:11 AM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Documentation
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 4.2.1Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Aug 2017 03:32:13 PM UTC, comment #3:

I checked in a change to the documentation here (http://hg.savannah.gnu.org/hgweb/octave/rev/551e4d1dd28f). Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Fri 04 Aug 2017 11:04:47 PM UTC, comment #2:

As a reference, Wikipedia (https://en.wikipedia.org/wiki/Toeplitz_matrix) indicates that the Toeplitz reference need not be square. Also, Matlab reference for the equivalent function (http://www.mathworks.com/help/matlab/ref/toeplitz.html).

Regarding TeX, I think we should be consistent between the Tex and non-TeX documentation. Choosing to be inconsistent, and then making sure that all documentation is inconsistent in exactly the same way, seems like hard work.

For reference, take a look and vander.m where the TeX and non-TeX documentation are in agreement, and both use c1 as the first column entry.

Rik <rik5>
Project Administrator
Thu 03 Aug 2017 04:14:30 PM UTC, comment #1:

Nice catch, but there are a couple things about this.

First, the documentation gives an example of a square matrix, but the toeplitz() routine appears to be more general, e.g.,

So, perhaps it should be row c(m) c(m-1) c(m-2) ... c(1) and column r(n) r(n-1) r(n-2) ... c(1). And remove the word "square".

The second issue is the conundrum of the fact that the example and help from an Octave script context is C(1), C(2), etc. However, the TeX script uses subscript notation c_?, c_?, etc. Should that TeX (i.e., math formula) notation start at 0 or 1? (If it starts at 0, the limits should be m-1 and n-1.)

Dan Sebald <sebald>
Thu 03 Aug 2017 06:49:11 AM UTC, original submission:

Instead of

I guess it should read

See attached patch

A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41400:  p_toeplitz_idx.txt added by arb (1KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by sebald (Posted a comment)
  • -unavailable- added by arb (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Aug 2017 03:32:13 PM UTCrik5StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 04 Aug 2017 11:04:47 PM UTCrik5StatusNone=>Confirmed
    Thu 03 Aug 2017 06:49:11 AM UTCarbAttached File-=>Added p_toeplitz_idx.txt, #41400

    Back to the top


    Powered by Savane 3.1-cleanup1