bugGNU Octave - Bugs: bug #51639, 'struct help_system' violates the...

 
 

bug #51639: 'struct help_system' violates the C++ One Definition Rule

Submitted by:  Dmitri A. Sergatskov <dasergatskov>
Submitted on:  Tue 01 Aug 2017 08:16:38 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 02 Aug 2017 08:19:03 PM UTC, comment #3:

Ah, I think the issue is that the real declaration/definition of interpreter is inside the octave namespace but the forward declaration in help.h is not.

Fixed with the following changeset and tested with GCC 7 and lto enabled. Closing report.

http://hg.savannah.gnu.org/hgweb/octave/rev/5111b1b5034d

John W. Eaton <jwe>
Project Administrator
Wed 02 Aug 2017 07:47:49 PM UTC, comment #2:

I'm looking at this now. I don't see how it could be OCT_INTERP_API since, as far as I can tell, that macro is currently always defined to be empty on all systems except MSVC.

John W. Eaton <jwe>
Project Administrator
Wed 02 Aug 2017 06:40:50 PM UTC, comment #1:

It's not a killer, but this should be fixed.

Is it fixed if you change llibinterp/corefcn/help.h:33 to

The compiler is pointing out that there are two declarations of the class interpreter, one with OCTINTERP_API and one without.

Rik <rik5>
Project Administrator
Tue 01 Aug 2017 08:16:38 PM UTC, original submission:

I noticed in fedora lto builds (gcc 7.1.1):

See e.g.:

Dmitri.

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by dasergatskov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Aug 2017 08:19:03 PM UTCjweStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1