bugCompact Disc Input and Control Library - Bugs: bug #51627, Fix build for Python 3

 
 

bug #51627: Fix build for Python 3

Submitted by:  None
Submitted on:  Mon 31 Jul 2017 12:44:01 PM UTC  
 
Category: compilationSeverity: 5 - Average
Item Group: pycdioStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Originator Email: -unavailable-Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 31 Jul 2017 11:18:12 PM UTC, comment #1:

Thanks for the bug report and patch.

I believe commit 05376be should address, but please double check.

Thanks.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Mon 31 Jul 2017 12:44:01 PM UTC, original submission:

The "#if PY_VERSION_HEX" in swig/device.swg is evaluated at the time of running swig, resulting in generated code that can be built only for Python 2.

Fix by changing "#if ..." to "%#if ....", so that the conditionals are evaluated only when actually compiling the code.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41374:  pycdio-swig-python3.patch added by None (565B - text/x-patch - Fix compilation for Python 3)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 31 Jul 2017 11:19:27 PM UTCrockyStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Mon 31 Jul 2017 11:18:12 PM UTCrockyStatusNone=>In Progress
      Assigned toNone=>rocky
    Mon 31 Jul 2017 12:44:01 PM UTCNoneAttached File-=>Added pycdio-swig-python3.patch, #41374

    Back to the top


    Powered by Savane 3.1-cleanup1