bugGNU roff - Bugs: bug #51598, [PATCH] test-groff.in: Add...

 
 

bug #51598: [PATCH] test-groff.in: Add directories to the search path for "tmac" files

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Fri 28 Jul 2017 12:18:40 AM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 15 Jun 2022 02:38:50 PM UTC, comment #4: 


commit ff85acc64647e562d59eeaad34f5672b6c684913
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Nov 2 07:16:23 2017 -0400

    test-groff.in: Recognize additional contrib tmacs.

    "tmac" files in the directories "contrib/hdtbl", "contrib/mm", and
    "contrib/pdfmark" are not included in the search path for "test-groff".
    That is of cause necessary to test those macro files and files using
    those.

    Fixes Savannah #51598.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>

    Break these hard-to-read declarations across lines so they're easier to
    maintain.

    Kill useless trailing whitespace.


G. Branden Robinson <gbranden>
Group administrator
Thu 02 Nov 2017 06:30:17 AM UTC, comment #3: 

Thanks, Bjarni!

G. Branden Robinson <gbranden>
Group administrator
Wed 01 Nov 2017 11:54:40 PM UTC, comment #2: 


  Here is the missing piece of the patch:

>From dfc992947776d61fc3439bc95eb77b5cb83fc8d6 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 27 Jul 2017 21:38:17 +0000
Subject: [PATCH] test-groff.in: Add directories to the search path for "tmac"
files

  "tmac" files in the directories "contrib/hdtbl", "contrib/mm", and
"contrib/pdfmark" are not included in the search path for "test-groff".
That is of cause necessary to test those macro files and files using those.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 test-groff.in | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/test-groff.in b/test-groff.in
index 357c3352..86e7dd5f 100644
--- a/test-groff.in
+++ b/test-groff.in
@@ -35,7 +35,11 @@ fi

 GROFF_COMMAND_PREFIX=
 GROFF_FONT_PATH=$builddir/font$SEP$srcdir/font
-GROFF_TMAC_PATH=$srcdir/tmac$SEP$builddir/tmac$SEP$srcdir/contrib/mom$SEP$builddir/contrib/mom
+GROFF_TMAC_PATH=$srcdir/tmac$SEP$builddir/tmac$SEP$srcdir/contrib/mom\
+$SEP$builddir/contrib/mom$SEP$srcdir/contrib/hdtbl$SEP$builddir/contrib/hdtbl\
+$SEP$srcdir/contrib/mm$SEP$builddir/contrib/mm\
+$SEP$srcdir/contrib/pdfmark$SEP$builddir/contrib/pdfmark
+
 export GROFF_BIN_PATH GROFF_COMMAND_PREFIX GROFF_FONT_PATH GROFF_TMAC_PATH

 exec $builddir/groff -b -ww ${1+"$@"}
--
2.13.2


Bjarni Ingi Gislason <bjarniig>
Wed 01 Nov 2017 03:29:03 AM UTC, comment #1: 

This is another one where Savannah ate Bjarni's content.

Bjarni, please follow up.

G. Branden Robinson <gbranden>
Group administrator
Fri 28 Jul 2017 12:18:40 AM UTC, original submission:  


From dfc992947776d61fc3439bc95eb77b5cb83fc8d6 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 27 Jul 2017 21:38:17 +0000
Subject: [PATCH] test-groff.in: Add directories to the search path for "tmac" files

  "tmac" files in the directories "contrib/hdtbl", "contrib/mm", and
"contrib/pdfmark" are not included in the search path for "test-groff".
That is of cause necessary to test those macro files and files using those.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 test-groff.in | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/test-groff.in b/test-groff.in
index 357c3352..86e7dd5f 100644
--- a/test-groff.in
+++ b/test-groff.in
@@ -35,7 +35,11 @@ fi

 GROFF_COMMAND_PREFIX=
 GROFF_FONT_PATH=$builddir/font$SEP$srcdir/font
-GROFF_TMAC_PATH=$srcdir/tmac$SEP$builddir/tmac$SEP$srcdir/contrib/mom$SEP$builddir/contrib/mom
+GROFF_TMAC_PATH=$srcdir/tmac$SEP$builddir/tmac$SEP$srcdir/contrib/mom\
+$SEP$builddir/contrib/mom$SEP$srcdir/contrib/hdtbl$SEP$builddir/contrib/hdtbl\
+$SEP$srcdir/contrib/mm$SEP$builddir/contrib/mm\
+$SEP$srcdir/contrib/pdfmark$SEP$builddir/contrib/pdfmark
+
 export GROFF_BIN_PATH GROFF_COMMAND_PREFIX GROFF_FONT_PATH GROFF_TMAC_PATH

 exec $builddir/groff -b -ww ${1+"$@"}
--
2.13.2

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-15 gbranden CategoryNone General
        Planned ReleaseNone 1.22.4
    2018-07-02 bgarrigues Open/ClosedOpen Closed
    2017-11-02 gbranden StatusIn Progress Fixed
    2017-11-02 gbranden StatusNeed Info In Progress
    2017-11-01 gbranden StatusNone Need Info
        Assigned toNone gbranden
    2017-09-01 bgarrigues Item GroupNone Build/Installation

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code