bugGNU roff - Bugs: bug #51587, [PATCH] src: preconv.cpp: Add a...

 
 

bug #51587: [PATCH] src: preconv.cpp: Add a missing comma in the argument list of "printf"

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Thu 27 Jul 2017 12:49:15 AM UTC
   
 
Category:  Preprocessor preconv Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  bgarrigues
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 15 Jun 2022 02:40:03 PM UTC, comment #2: 


commit 613cef113767254cbb2cbb988b5b1124c1fdb0ca
Author: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date:   Sat Aug 26 00:29:51 2017 +0200

    `preconv --version' crashes.

    See bug at: https://savannah.gnu.org/bugs/?51587.

    * src/preproc/preconv/preconv.cpp: Add a missing comma in the
    argument list of "printf".


G. Branden Robinson <gbranden>
Group administrator
Fri 25 Aug 2017 10:31:27 PM UTC, comment #1: 

Commited, thanks.

Bertrand Garrigues <bgarrigues>
Group administrator
Thu 27 Jul 2017 12:49:15 AM UTC, original submission:  


From cc61328abb08b05a648fd923a6ff6d23433a2b4f Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 27 Jul 2017 00:16:37 +0000
Subject: [PATCH] src: preconv.cpp: Add a missing comma in the argument list of
 "printf"

  Warning by "gcc" version 6.4.0 with:

CFLAGS='-Wall -Wextra -Wformat=2 -Wmissing-prototypes -Wmissing-declarations'
CFLAGS="$CFLAGS "'-Wold-style-definition -Wstrict-prototypes'
CFLAGS="$CFLAGS "'-fstack-protector-strong -fno-common -funsigned-char'

CXXFLAGS="$CFLAGS "'-Wold-style-cast'

src/preproc/preconv/preconv.cpp: In function 'int main(int, char**)':
src/preproc/preconv/preconv.cpp:1233:6: warning: format '%s' expects a matching 'char*' argument [-Wformat=]
      );

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/preproc/preconv/preconv.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/preproc/preconv/preconv.cpp b/src/preproc/preconv/preconv.cpp
index b7241b0b..35e22eda 100644
--- a/src/preproc/preconv/preconv.cpp
+++ b/src/preproc/preconv/preconv.cpp
@@ -1221,9 +1221,9 @@ main(int argc, char **argv)
       printf("GNU preconv (groff) version %s %s iconv support and %s uchardet support\n",
              Version_string,
 #ifdef HAVE_ICONV
-             "with"
+             "with",
 #else
-             "without"
+             "without",
 #endif /* HAVE_ICONV */
 #ifdef HAVE_UCHARDET
              "with"
--
2.13.2


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-15 gbranden CategoryNone Preprocessor preconv
        Assigned toNone bgarrigues
        Planned ReleaseNone 1.22.4
    2017-08-25 bgarrigues StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code