bugGNU roff - Bugs: bug #51482, [PATCH] test-groff.in: Add options...

 
 

bug #51482: [PATCH] test-groff.in: Add options enabling warnings and backtrace

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sun 16 Jul 2017 08:04:54 PM UTC
   
 
Category:  General Severity:  1 - Wish
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 27 May 2021 09:11:02 AM UTC, comment #5: 

comment #4:

> We've changed course on this per recent discussion on the groff mailing list.


For groff historians, said discussion being the one starting at http://lists.gnu.org/archive/html/groff/2021-04/msg00022.html

Dave <barx>
Group Member
Fri 30 Apr 2021 02:41:30 PM UTC, comment #4: 

We've changed course on this per recent discussion on the groff mailing list.



commit 5aaf04cdf6e8ca194e4c8af2678d4c2743677903
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Apr 30 21:53:53 2021 +1000

    test-groff.in: Stop passing groff -b and -ww.

    * test-groff.in: Stop passing the built groff executable -b and -ww
      options by default.  This reverses a change from 2017.  Dave Kemper
      has convincingly argued that there's no way to override -b and turn
      backtraces on warnings/errors back off, and that the built groff
      should behave as much like a "normal" one as possible.  The latter
      factor is of added importance now that we are using test-groff for
      generation of documents.

    * src/roff/groff/tests/regression_savannah_58153.sh: Adapt.

    If you're a bleeding edge groff user who runs it straight from
    build trees, I recommend writing shell aliases or functions to
    capture the desired behavior.

            alias tg='./build/test-groff -b -ww'
            alias tgu='./build/test-groff -b -ww -Tutf8'


G. Branden Robinson <gbranden>
Group administrator
Thu 22 Apr 2021 07:09:55 PM UTC, comment #3: 


commit 655e5020ed46cb77e7e5a80282bec5ccc3284282
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Nov 18 18:25:16 2017 -0500

    test-groff.in: Enable backtraces and all warnings.

    Fix bug https://savannah.gnu.org/bugs/?51482.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
    Signed-off-by: G. Branden Robinson <g.branden.robinson@gmail.com>


G. Branden Robinson <gbranden>
Group administrator
Sat 18 Nov 2017 11:18:00 PM UTC, comment #2: 

The part of this that applies to troff(1) is a duplicate of Savannah #47784, according to Bertrand's commit 8ca41399a2449fe5d619a6edd292c127c891f4e7 (28 August).

G. Branden Robinson <gbranden>
Group administrator
Sun 16 Jul 2017 08:07:52 PM UTC, comment #1: 

  Forgot to add "minus vervatim minus" at the end of patch for the web-page


From 8c8036707fea01b4f415da083ae3f19d70ddb3eb Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sun, 16 Jul 2017 19:55:24 +0000
Subject: [PATCH] test-groff.in; troff.1.man: Add options for warnings and
 backtrace; change "-w all" to " -ww"

  This is a test version, so as much code as possible should be used by
default.

  Actually all warnings should be enabled by default; the current default
choice is simple an illusion, telling people everything is o.k., when it
actually is not always the case.

  This is also a contradiction, maintainers have created warnings, and yet
silence them (no free speech, must be extra asked for).

  How do people already know that every input they use is already free of
errors, bad constructs etc.

  Does your experience proof that every man-page (source file) is free of
everything that "groff" is constructed to warn about?

  Is this philosophy "all warnings are equal but some are more equal than
others", a good one, a fundamental one, a paradigm in computer science?

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/roff/troff/troff.1.man | 2 +-
 test-groff.in              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/roff/troff/troff.1.man b/src/roff/troff/troff.1.man
index 0df947bb..bc9b51b0 100644
--- a/src/roff/troff/troff.1.man
+++ b/src/roff/troff/troff.1.man
@@ -299,7 +299,7 @@ below.
 .
 For example, to enable all warnings, use
 .B \-w
-.BR all .
+.BR w .
 Multiple
 .B \-w
 options are allowed.
diff --git a/test-groff.in b/test-groff.in
index 953299b6..357c3352 100644
--- a/test-groff.in
+++ b/test-groff.in
@@ -38,4 +38,4 @@ GROFF_FONT_PATH=$builddir/font$SEP$srcdir/font
 GROFF_TMAC_PATH=$srcdir/tmac$SEP$builddir/tmac$SEP$srcdir/contrib/mom$SEP$builddir/contrib/mom
 export GROFF_BIN_PATH GROFF_COMMAND_PREFIX GROFF_FONT_PATH GROFF_TMAC_PATH

-exec $builddir/groff ${1+"$@"}
+exec $builddir/groff -b -ww ${1+"$@"}
--
2.13.2


Bjarni Ingi Gislason <bjarniig>
Sun 16 Jul 2017 08:04:54 PM UTC, original submission:  

  Actually all warnings should be enabled by default; the current default
choice is simple an illusion, telling people everything is o.k., when it
actually is not always the case.

  This is also a contradiction, maintainers have created warnings, and yet
silence them (no free speech, must be extra asked for).

  How do people already know that every input they use is already free of
errors, bad constructs etc.

  Does your experience proof that every man-page (source file) is free of
everything that "groff" is constructed to warn about?

  Is this philosophy "all warnings are equal but some are more equal than
others", a good one, a fundamental one, a paradigm in computer science?



From 8c8036707fea01b4f415da083ae3f19d70ddb3eb Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sun, 16 Jul 2017 19:55:24 +0000
Subject: [PATCH] test-groff.in; troff.1.man: Add options for warnings and
 backtrace; change "-w all" to " -ww"

  This is a test version, so as much code as possible should be used by
default.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/roff/troff/troff.1.man | 2 +-
 test-groff.in              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/roff/troff/troff.1.man b/src/roff/troff/troff.1.man
index 0df947bb..bc9b51b0 100644
--- a/src/roff/troff/troff.1.man
+++ b/src/roff/troff/troff.1.man
@@ -299,7 +299,7 @@ below.
 .
 For example, to enable all warnings, use
 .B \-w
-.BR all .
+.BR w .
 Multiple
 .B \-w
 options are allowed.
diff --git a/test-groff.in b/test-groff.in
index 953299b6..357c3352 100644
--- a/test-groff.in
+++ b/test-groff.in
@@ -38,4 +38,4 @@ GROFF_FONT_PATH=$builddir/font$SEP$srcdir/font
 GROFF_TMAC_PATH=$srcdir/tmac$SEP$builddir/tmac$SEP$srcdir/contrib/mom$SEP$builddir/contrib/mom
 export GROFF_BIN_PATH GROFF_COMMAND_PREFIX GROFF_FONT_PATH GROFF_TMAC_PATH

-exec $builddir/groff ${1+"$@"}
+exec $builddir/groff -b -ww ${1+"$@"}
--
2.13.2

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by barx (Posted a comment)
  • -email is unavailable- added by bgarrigues (Updated the item)
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden CategoryNone General
        Item GroupNone Build/Installation
    2021-04-22 gbranden Severity3 - Normal 1 - Wish
        Planned ReleaseNone 1.22.4
    2018-07-02 bgarrigues Open/ClosedOpen Closed
    2017-11-18 gbranden StatusIn Progress Fixed
    2017-11-18 gbranden Summary[PATCH] test-groff.in; troff.1.man: Add options for warnings and backtrace; change &quot;-w all&quot; to &quot; -ww&quot; [PATCH] test-groff.in: Add options enabling warnings and backtrace
    2017-11-18 gbranden StatusNone In Progress
        Assigned toNone gbranden
    2017-11-10 gbranden SummaryPATCH] test-groff.in; troff.1.man: Add options for warnings and backtrace; change &quot;-w all&quot; to &quot; -ww&quot; [PATCH] test-groff.in; troff.1.man: Add options for warnings and backtrace; change "-w all" to " -ww"

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code