bugGNU Octave - Bugs: bug #51460, allow cursor flashing to be...

 
 

bug #51460: allow cursor flashing to be configured globally

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 13 Jul 2017 05:51:11 PM UTC  
 
Category: GUISeverity: 1 - Wish
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 30 Jul 2017 03:34:38 AM UTC, comment #10:

Tested and works for me, pushed on the default branch

https://hg.savannah.gnu.org/hgweb/octave/rev/9c24aae7515f

Thanks Torsten.

Mike Miller <mtmiller>
Project Administrator
Fri 28 Jul 2017 04:57:09 PM UTC, comment #9:

@Mike: Do you want to review and commit the patch?

Rik <rik5>
Project Administrator
Sun 23 Jul 2017 10:03:59 AM UTC, comment #8:

Oh, wrong attachement in my previous comments. Here is the correct patch (v3).

(file #41298)

Torsten <ttl>
Project Member
Sun 23 Jul 2017 08:57:46 AM UTC, comment #7:

Attached the updated patch (v2). Terminal and editor still needs special handling, since the terminal uses a separate timer for cursor blinking and QScintilla obviously ignores the application wide settings, too.

(file #41295)

Torsten <ttl>
Project Member
Sun 23 Jul 2017 02:03:55 AM UTC, comment #6:

Oops, I thought I had shown my proof of concept patch already.

This quick and dirty change disables all blinking for me.

The argument is in milliseconds, with a default of 1000 (or query the previous value with QApplication::cursorFlashTime).

This call is safe for all Qt versions.

Mike Miller <mtmiller>
Project Administrator
Sat 22 Jul 2017 07:51:19 PM UTC, comment #5:

I have attached a patch that moves the preference for cursor blinking from the terminal to the general settings tab. If it is not yet set, then the old terminal cursor blinking preference is used.

@Mike: In comment #1 you said that you know how to set the cursor blinking for the whole application. We now just have to add this.

(file #41292)

Torsten <ttl>
Project Member
Mon 17 Jul 2017 07:34:05 PM UTC, comment #4:

Sounds good to me.

I think we should also make sure to comment that this could be deprecated / removed someday if Qt ever adds support for getting the cursor blink preferences from all OS environments that we support.

Mike Miller <mtmiller>
Project Administrator
Fri 14 Jul 2017 07:23:05 PM UTC, comment #3:

I think the preference string should also move. We can keep compatibility by using QSettings::contains () for testing the existence of the new settings key and to fall back to the old in case the new one does not exist.

Torsten <ttl>
Project Member
Fri 14 Jul 2017 05:30:20 PM UTC, comment #2:

Yes I do think General makes more sense.

Should the preference string also be moved to the "[General]" section of the settings file?

Do we try to keep backwards compatibility for the settings file or would this just be set to the default value when it changes?

Mike Miller <mtmiller>
Project Administrator
Thu 13 Jul 2017 07:03:14 PM UTC, comment #1:

I like your idea to have one setting for cursor blinking across the entire application. Should this setting then move from the "Terminal" into the "General" tab?

Torsten <ttl>
Project Member
Thu 13 Jul 2017 05:51:11 PM UTC, original submission:

The GUI currently has an option in the Terminal tab of the Preferences dialog to choose whether the cursor blinks or not in the command window.

I would like a way to disable cursor blinking across the entire application. In Qt 4 it was possible to disable this using the qtconfig tool, works for me.

In Qt 5, they have overhauled the way this is set, relying instead on the operating system to set defaults for user interface tweaks like this. Unfortunately this is not implemented in Qt 5 for any GNU/Linux desktop environments yet. So it is up to applications to allow the cursorFlashTime setting to be configured individually.

I know how to set this, but I would like input from the GUI experts on whether this should be a separate setting, or whether it should derive from the same setting as the one currently in the Terminal tab. Personally I think it's weird to have a "Cursor blinking" option that only applies to the command window and not to the rest of the application as well.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41298:  bug51460_v3.patch added by ttl (18KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Jul 2017 03:34:38 AM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Sun 23 Jul 2017 10:04:17 AM UTCttlAttached File#41295=>Removed
    Sun 23 Jul 2017 10:04:10 AM UTCttlAttached File#41292=>Removed
    Sun 23 Jul 2017 10:03:59 AM UTCttlAttached File-=>Added bug51460_v3.patch, #41298
    Sun 23 Jul 2017 08:57:46 AM UTCttlAttached File-=>Added bug51460_v2.patch, #41295
      StatusNone=>Patch Submitted
    Sat 22 Jul 2017 07:51:19 PM UTCttlAttached File-=>Added bug51460_v1.patch, #41292

    Back to the top


    Powered by Savane 3.1-cleanup1