bugmake - Bugs: bug #51400, SIGCHLD gets unblocked

 
 

bug #51400: SIGCHLD gets unblocked

Submitter:  Koen Van Hoof <kvho>
Submitted:  Thu 06 Jul 2017 09:29:48 AM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.2.1 Operating System:  POSIX-Based
Fixed Release:  4.3 Triage Status:  Medium Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 10 Jul 2017 01:58:48 AM UTC, comment #1: 

Thanks for the report!

The change needs to be slightly more complicated, since there are some parts of the code (after fork, in the child process) where we really do want to unblock all signals.

The fix has been pushed to Git and will be available in the next release.

Paul D. Smith <psmith>
Group administrator
Thu 06 Jul 2017 09:29:48 AM UTC, original submission:  

in main.c SIGCHLD is blocked.
in unblock_sigs in job.c, the signal is unblocked again.

solution:
diff --git a/src/job.c b/src/job.c
--- a/src/job.c
+++ b/src/job.c
@@ -1051,9 +1051,7 @@ block_sigs (void)
 void
 unblock_sigs (void)
 {
-  sigset_t empty;
-  sigemptyset (&empty);
-  sigprocmask (SIG_SETMASK, &empty, (sigset_t *) 0);
+  (void) sigprocmask (SIG_UNBLOCK, &fatal_signal_set, (sigset_t *) 0);
 }
 #endif

Koen Van Hoof <kvho>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by kvho (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-07-10 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.3
        Triage StatusNone Medium Effort

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code