GNU nano - Bugs: bug #51370, the quoting regime in the syntax...
You are not allowed to post comments on this tracker with your current authentication level.
bug #51370: the quoting regime in the syntax files is inconsistent
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Mon 03 Jul 2017 09:20:48 AM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Fri 07 Jul 2017 08:32:19 AM UTC, comment #9: |
Benno Schulenberg <bens> |
Thu 06 Jul 2017 09:06:41 PM UTC, comment #8: I think I did miss it. Tried again with the entire sequence: your new first patch, plus your other two (0001 through 0003), and they still seem to work well as a whole (after I put back my nanorcs for testing).
|
David Lawrence Ramsey <dolorous> |
Thu 06 Jul 2017 08:06:20 PM UTC, comment #7: Here is the documentation patch, and a follow-on patch to simplify the comment inhibition. (And maybe you missed my reworked first patch, as we posted almost at the same time.) |
Benno Schulenberg <bens> |
Thu 06 Jul 2017 07:23:51 PM UTC, comment #6: Your patch does seem to work so far; thanks. However, while testing it, I found another bug which I had to hack around first in order to verify that your patch worked. But I'll report that separately too. |
David Lawrence Ramsey <dolorous> |
Thu 06 Jul 2017 07:21:32 PM UTC, comment #5: The first patch didn't do the right thing when the argument /didn't/ start with a double quote. Attached is a second attempt. |
Benno Schulenberg <bens> |
Thu 06 Jul 2017 11:09:40 AM UTC, comment #4: Here's a first, rough patch. It should fix this bug (never requiring double quotes to be escaped) and bug #51394.
|
Benno Schulenberg <bens> |
Wed 05 Jul 2017 08:30:01 PM UTC, comment #3: I figured that if there was an inconsistency in the documentation regarding comment quoting, I should verify what the comment quoting code actually did, just in case something was off. I'll go ahead and report it as a separate bug, though.
|
David Lawrence Ramsey <dolorous> |
Wed 05 Jul 2017 07:05:14 PM UTC, comment #2: So... you found a bug: when the comment string is actually empty, it should have disabled commenting, but in fact it doesn't. I think that should have been reported as a separate bug.
|
Benno Schulenberg <bens> |
Tue 04 Jul 2017 09:26:27 PM UTC, comment #1: I've tested this with current git (7473105), and parsing of the comment string is odd. Despite what the documentation says, backslashing of double quotes is actually required for the comment option, since the comment string is parsed via rcfile.c:pick_up_name(), which requires such backslashing. However, not backslashing double quotes leads to erroneous commenting behavior without generating errors. You can reproduce it via the following steps:
|
David Lawrence Ramsey <dolorous> |
Mon 03 Jul 2017 09:20:48 AM UTC, original submission:
In the beginning of the nanorc manpage, it says: "Quotes inside these string parameters don't have to be escaped with backslashes." But later on, for the "comment string" directive, it says that double quotes need to be backslashed. That is not consistent. |
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-07-22 | bens | Open/Closed | Open | Closed | |
2017-07-07 | bens | Status | In Progress | Fixed | |
2017-07-06 | bens | Attached File | - | Added 0002-docs-remove-the-mention-of-backslashes-for-the-argum.patch, #41138 | |
Attached File | - | Added 0003-tweaks-recognize-the-empty-string-as-comment-inhibit.patch, #41139 | |||
2017-07-06 | bens | Attached File | - | Added 0001-rcfile-don-t-require-backslashing-in-the-argument-of.patch, #41135 | |
2017-07-06 | bens | Attached File | - | Added 0001-rcfile-don-t-require-backslashing-in-the-argument-of.patch, #41133 | |
Status | None | In Progress | |||
Assigned to | None | bens |
Powered by Savane 3.13-d3ae.
Corresponding source code
Fixed in git, by a7901dd1e, and completed by 79971a30.