bugGNU Octave - Bugs: bug #51321, end keyword used as index disrupts...

 
 

bug #51321: end keyword used as index disrupts code folding

Submitted by:  Marshall <marsian>
Submitted on:  Mon 26 Jun 2017 11:09:25 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: John Donoghue <lostbard>
Originator Name: MarsianOpen/Closed: Closed
Release: 4.2.1Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Jul 2017 12:52:28 PM UTC, comment #5:

closing as fixed for mxe. The upstream fix will slowly make its way into qscintilla

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 06 Jul 2017 01:10:22 PM UTC, comment #4:

Gor mxe-octave, added a patch for qscintilla: http://hg.octave.org/mxe-octave/rev/ca55304a3cfd

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 28 Jun 2017 04:05:28 PM UTC, comment #3:

Posted upstream with scintilla fix: https://sourceforge.net/p/scintilla/bugs/1951/

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 28 Jun 2017 03:34:08 PM UTC, comment #2:

Confirmed - its really an issue with Scintilla, but octave for windows is using updated code compared to what is used for standard qscintilla on Linux.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 27 Jun 2017 04:21:39 PM UTC, comment #1:

I found that 'while' is not matched to end statements, for code folding either. That by itself is not a problem (though I think it should), but that means the end for a while then becomes a mismatch for other folding statements so that any statements after it aren't properly marked for folding. E.g. :

Marshall <marsian>
Mon 26 Jun 2017 11:09:25 PM UTC, original submission:

The 'end' keyword breaks proper code folding when used as an index to an array:

Each 'end' used as an index will be matched improperly with the prior control statement, and won't be collapsed completely. Surrounding and following lines are shown to match to the wrong end statements, or for the last 'if' doesn't show any match lines, but still folds.

Marshall <marsian>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by marsian (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Jul 2017 12:52:28 PM UTClostbardStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 06 Jul 2017 01:10:22 PM UTClostbardItem GroupNone=>Incorrect Result
      StatusConfirmed=>Ready For Test
    Wed 28 Jun 2017 03:34:08 PM UTClostbardStatusNone=>Confirmed
      Assigned toNone=>lostbard

    Back to the top


    Powered by Savane 3.1-cleanup1