bugGNU Octave - Bugs: bug #51273, [octave-forge] (sockets) function...

 
 

bug #51273: [octave-forge] (sockets) function MSG_DONTWAIT and MSG_WAITALL should have error fallbacks defined

Submitted by:  None
Submitted on:  Tue 20 Jun 2017 09:43:17 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 3 - LowItem Group: Unexpected Error
Status: Patch SubmittedAssigned to: None
Originator Name: Ilkka KontolaOriginator Email: -unavailable-
Open/Closed: OpenRelease: 4.0.3
Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 21 Jun 2017 04:58:37 PM UTC, comment #7:

Patched added. Its been a while since sockets was last released so also needs updates for base level Makefile etc (not included in patch)

(file #41014)

John Donoghue <lostbard>
Project Member
Tue 20 Jun 2017 06:13:27 PM UTC, comment #6:

That's a good idea. Both MSG_DONTWAIT and MSG_WAITALL are defined within an ifdef, so both should have these workaround error functions if the constants are not defined. Updating summary

Mike Miller <mtmiller>
Project Administrator
Tue 20 Jun 2017 06:07:58 PM UTC, comment #5:

The documentation doesn't mention anything about constants available or not available depending on OS, so I guess either document that, or do the same as AF_LOCAL, where it is changed to a function on non-supported systems so it can throw back an error message that it isn't supported?

John Donoghue <lostbard>
Project Member
Tue 20 Jun 2017 05:28:59 PM UTC, comment #4:

So the bug is that the package is behaving as designed. It intentionally does not define wrappers for constants that are not declared on a given operating system. Is this unclear to the user? Does someone have a suggestion to improve this for the user experience?

Mike Miller <mtmiller>
Project Administrator
Tue 20 Jun 2017 12:25:27 PM UTC, comment #3:

Looks like MSG_DONTWAIT is not supported in windows.

https://msdn.microsoft.com/en-us/library/windows/desktop/ms740121(v=vs.85).aspx

John Donoghue <lostbard>
Project Member
Tue 20 Jun 2017 12:20:03 PM UTC, comment #2:

In windows, sockets 1.2.0, I see:

John Donoghue <lostbard>
Project Member
Tue 20 Jun 2017 11:02:23 AM UTC, comment #1:

Why do you think it's undefined? It's in https://sourceforge.net/p/octave/sockets/ci/default/tree/src/socket.cc#l112

Andreas Weber <andy1978>
Project Member
Tue 20 Jun 2017 09:43:17 AM UTC, original submission:
Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41014:  bug51273.patch added by lostbard (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by lostbard (Adding package maintainer)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by andy1978 (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Aug 2017 05:34:42 PM UTCjweSummary[octave-forge] sockets function MSG_DONTWAIT and MSG_WAITALL should have error fallbacks defined=>[octave-forge] (sockets) function MSG_DONTWAIT and MSG_WAITALL should have error fallbacks defined
    Fri 11 Aug 2017 05:30:34 PM UTCjweSummarysockets package: function MSG_DONTWAIT and MSG_WAITALL should have error fallbacks defined=>[octave-forge] sockets function MSG_DONTWAIT and MSG_WAITALL should have error fallbacks defined
    Wed 21 Jun 2017 04:58:37 PM UTClostbardAttached File-=>Added bug51273.patch, #41014
      StatusConfirmed=>Patch Submitted
      Carbon-Copy-=>Added pauldreik
    Tue 20 Jun 2017 06:13:27 PM UTCmtmillerPriority5 - Normal=>3 - Low
      StatusNeed Info=>Confirmed
      Summarysockets package function recv flag MSG_DONTWAIT undefined=>sockets package: function MSG_DONTWAIT and MSG_WAITALL should have error fallbacks defined
    Tue 20 Jun 2017 11:03:17 AM UTCandy1978StatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup1