bugGNU Octave - Bugs: bug #51221, deconv possibly inaccurate

 
 

bug #51221: deconv possibly inaccurate

Submitted by:  Marco Caliari <caliari>
Submitted on:  Sun 11 Jun 2017 09:47:14 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Inaccurate Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 08 Oct 2017 04:18:38 PM UTC, comment #7:

The original test_deconv.m script works for me now, closing as fixed.

Mike Miller <mtmiller>
Project Administrator
Tue 29 Aug 2017 08:24:18 PM UTC, comment #6:

I applied the changes by hand and pushed here:

http://hg.savannah.gnu.org/hgweb/octave/rev/6cc3aafbdc41

John W. Eaton <jwe>
Project Administrator
Tue 29 Aug 2017 06:59:23 PM UTC, comment #5:

The proposed patch no longer applies after this changeset from Rik:

http://hg.savannah.gnu.org/hgweb/octave/rev/613934236291

John W. Eaton <jwe>
Project Administrator
Wed 14 Jun 2017 12:55:54 PM UTC, comment #4:

Now it works for me, too. Thanks again.

Anonymous
Wed 14 Jun 2017 11:24:09 AM UTC, comment #3:

Sorry, try deconv2.diff instead. Your original testcase now works for me.

(file #40916)

Marco Caliari <caliari>
Project Member
Wed 14 Jun 2017 09:05:54 AM UTC, comment #2:

Thank you very much for working on this, Marco. Did you try to run my original testcase from bug report #51148 with the patch? I am still getting an error (but I may have made a mistake when I patched the functions by hand):

Anonymous
Wed 14 Jun 2017 07:04:11 AM UTC, comment #1:

I figured out how filter works and propose the attached patch. I would like to improve the documentation of filter for people like me which do not understand the meaning of "initial state of the system" or similar. I would like to describe SI and SF in terms of "simple" (for me) linear equations. Anybody disagrees? Should I make a patch vs stable or default?

(file #40913)

Marco Caliari <caliari>
Project Member
Sun 11 Jun 2017 09:47:14 AM UTC, original submission:

This is a spin-off of bug report #51148. It seems that either deconv or filter is inaccurate for certain input. I attach a file from which I understand that 1) deconv is inaccurate and 2) the second output of filter, which seems accurate, could be used to compute the second output of deconv (currently, it is not done). Anybody has a better idea of the connection between filter and deconv?

Marco Caliari <caliari>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40916:  deconv2.diff added by caliari (2KiB - application/x-tex)
file #40913:  deconv.diff added by caliari (2KiB - application/x-tex)
file #40896:  test_deconv.m added by caliari (593B - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by jwe
  • -unavailable- added by caliari (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Oct 2017 04:18:38 PM UTCmtmillerStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 29 Aug 2017 08:24:18 PM UTCjweStatusPatch Submitted=>Ready For Test
    Tue 29 Aug 2017 06:59:23 PM UTCjweCarbon-Copy-=>Added rik
    Thu 15 Jun 2017 11:55:20 AM UTCcaliariStatusNone=>Patch Submitted
    Wed 14 Jun 2017 11:24:09 AM UTCcaliariAttached File-=>Added deconv2.diff, #40916
    Wed 14 Jun 2017 07:04:11 AM UTCcaliariAttached File-=>Added deconv.diff, #40913
    Sun 11 Jun 2017 09:47:14 AM UTCcaliariAttached File-=>Added test_deconv.m, #40896

    Back to the top


    Powered by Savane 3.1-cleanup1