bugGNU Octave - Bugs: bug #51090, pkg DESCRIPTION should not contain...

 
 

bug #51090: pkg DESCRIPTION should not contain duplicate keywords

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Tue 23 May 2017 01:10:53 AM UTC  
 
Category: Octave FunctionSeverity: 2 - Minor
Priority: 3 - LowItem Group: Documentation
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 24 May 2017 12:12:47 AM UTC, comment #3:

Fixed the docs and the pkg subfunction get_description on the default branch. I did not apply this to the stable branch because it changes behavior very slightly, if a package DESCRIPTION file somewhere out there has duplicates of any lines and is depending on the last one being preserved instead of the first when the package is loaded.

The doc fix itself could be applied to stable but it's so trivial and goes along with the rest of this change.

https://hg.savannah.gnu.org/hgweb/octave/rev/645d1f5f2cb2

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 23 May 2017 11:59:58 PM UTC, comment #2:

I've got this fixed locally already, pushing soon.

It's mentioned in package.txi.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 23 May 2017 11:44:00 PM UTC, comment #1:

I tried

but didn't find anything in the manual. Where is the manual documentation for 'pkg DESCRIPTION file'?

Rik <rik5>
Project Administrator
Tue 23 May 2017 01:10:53 AM UTC, original submission:

The manual says the following about the pkg DESCRIPTION file:

> Multiple dependencies can be defined either as a comma separated list or on separate Depends lines.


This is actually incorrect, subsequent Depends lines replace previous lines.

In addition to fixing this doc error, I would also like to see warnings from pkg when it parses a DESCRIPTION file that contains duplicate keywords. Since this shouldn't be done, it doesn't really matter whether the first or last is kept, so I would change it to keep the first instance and warn about duplicates.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 24 May 2017 12:12:47 AM UTCmtmillerStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Tue 23 May 2017 11:59:58 PM UTCmtmillerStatusNone=>In Progress
    Tue 23 May 2017 11:44:00 PM UTCrik5Priority5 - Normal=>3 - Low

    Back to the top


    Powered by Savane 3.1-cleanup1