bugGNU nano - Bugs: bug #50918, in current git, cursor visibility...

 
 

bug #50918: in current git, cursor visibility is inconsistent when searching help text

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Tue 02 May 2017 05:11:34 PM UTC  
 
Severity: 2 - MinorStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 03 May 2017 03:07:12 PM UTC, comment #4:

Thanks for testing. Pushed to git master, 9c2bc688.

And closing because unreleased.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Wed 03 May 2017 02:30:36 PM UTC, comment #3:

Looks good, after some quick testing.

David Lawrence Ramsey <dolorous>
Project Administrator
Wed 03 May 2017 10:40:51 AM UTC, comment #2:

Attached patch fixes it. If you have time to test...

(file #40570)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 02 May 2017 07:28:00 PM UTC, comment #1:

> but when there is no match, or when you move away from the
> match, should it still be visible then?


Good point. When there is no match, the cursor certainly shouldn't be shown, as it distracts from the message on the status bar. And when moving around after having searched... yes, it would be most consistent to switch the cursor back off again.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 02 May 2017 05:11:34 PM UTC, original submission:

In current git (3d1ef8e), the cursor is supposed to be invisible while in the help browser, but certain circumstances can leave it visible, and not all of them may be desirable. These circumstances can be reproduced as follows (assuming an en_US locale):

Scenario 1:

1. Start nano, and press Ctrl-G to enter the help browser.

2. Press Ctrl-W in the help browser, and enter "replace" at the search prompt. The cursor will become visible, and end up at the first character of the first instance of "replace".

Scenario 2:

1. Start nano, and press Ctrl-G to enter the help browser.

2. Press Ctrl-W in the help browser, and enter "xyzzy" at the search prompt. The cursor will become visible, but remain where it was, since "xyzzy" occurs nowhere in the help text.

In either case, the cursor still remains visible when you move vertically via Up, Down, PageUp, PageDown, Meta-\ or Meta-/ after searching. However, it becomes invisible again when you press (for example) Left or Right, after nano displays the "Unbound key" warning. Having the cursor be visible when you successfully find a match may be desirable, since it draws attention to the match, but when there is no match, or when you move away from the match, should it still be visible then?

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40570:  make-didfind-global.patch added by bens (2KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 May 2017 03:07:12 PM UTCbensSeverity3 - Normal=>2 - Minor
      StatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Wed 03 May 2017 10:40:51 AM UTCbensAttached File-=>Added make-didfind-global.patch, #40570
      StatusNone=>In Progress
      Assigned toNone=>bens

    Back to the top


    Powered by Savane 3.1-cleanup1