Wed 08 Mar 2017 09:48:21 AM UTC, comment #9:
Build results of the fixed patch (file #39935) on my system are as follows...
On-tree build, 144e082 on `master` branch:
On-tree build, detached HEAD at 144e082:
Off-tree build, 144e082 on `master` branch:
Off-tree build, detached HEAD at 144e082:
You would see that the version displays are now showing expected branch nickname in both normal and detached-HEAD repository, and in both on-tree and off-tree build configuration.
Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
|
Tue 07 Mar 2017 10:12:48 AM UTC, comment #4:
Patch included, see below.
These patches use a combination of `git symbolic-ref -q HEAD` and `basename` to determine current branch. All of them do the same thing, but use a different placeholder branch nickname when current branch cannot be determined; only one can be chosen for inclusion in mainline.
Choice 1. Use "none" when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch.patch (file #39917)
(Screenshot of About Gnash dialog: file #39918)
Choice 2. Use "unknown" when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch-unknown-placeholder.patch (file #39919)
(Screenshot of About Gnash dialog: file #39920)
Choice 3. Use pre-written version from configure.ac's `AC_INIT` when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch-version-placeholder.patch (file #39921)
(Screenshot of About Gnash dialog: file #39922)
Portability notes:
- A use of `basename` shouldn't be problem since `configure` is already using it.
- `git symbolic-ref -q HEAD` works in expected manner at least in Git 1.5.6.5, 1.7.10.4, and 2.11.1.
Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
|
Sun 05 Mar 2017 03:59:04 PM UTC, original submission:
This is a minor issue, but it would be nice if it get fixed.
While I was going back and forth in local Gnash Git repository, I ran into some oddity when I leave the repository in detatched HEAD mode (a la `git checkout REVSHA1`): I found that Gnash built from that repository would show a weird version string:
You would see that the branch part displayed in the version string is "(no", which is not normal; and this oddity also show up in GTK-Gnash's About dialog too (see the attached screenshot).
This problem does not seem to affect usability of the build, though it may cause confusion when user try to report bugs in Gnash built from that kind of repository configuration.
Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
|