bugGNU nano - Bugs: bug #50293, in current git, an offscreen start...

 
 

bug #50293: in current git, an offscreen start match is overlooked

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Mon 13 Feb 2017 09:51:40 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 13 Feb 2017 10:20:38 AM UTC, comment #1:

Fixed in git, 7ef5c532.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 13 Feb 2017 09:51:40 AM UTC, original submission:

To reproduce, run 'src/nano --syntax=c xxx'. Then type:

/* Hey

hey *

That is: four lines, and without the terminating slash that would finish the comment. Now press and hold <Enter> until all of the text has scrolled offscreen. Then type M-G 1,6 <Enter>. The cursor now sits on the "y" of "Hey". Type M-= three times to scroll the "Hey" three lines offscreen. The cursor sits after the star after "hey". Now type the terminating slash (/). The "hey" does not get colored. But it should.

When we find an unpaired startmatch, we shouldn't mark that line as CNONE. We have to mark that line as CWOULDBE, and every line after it too, so that, when the user finally types the matching end string for an offscreen startmatch, the painting routine (when it starts to paint the first line of the screen) knows it has to check for an end match -- instead of being fooled by a CNONE that there is nothing unpaired before the topline.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 13 Feb 2017 06:50:54 PM UTCbensOpen/ClosedOpen=>Closed
    Mon 13 Feb 2017 10:20:38 AM UTCbensStatusIn Progress=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1