bugGNU nano - Bugs: bug #50292, in current git, new multiline...

 
 

bug #50292: in current git, new multiline matches don't get colored

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Mon 13 Feb 2017 09:00:56 AM UTC  
 
Severity: 4 - ImportantStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 13 Feb 2017 09:29:41 AM UTC, comment #1:

Fixed in git, 6bd94040.

(But... a more subtle version of this bug is coming up.)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 13 Feb 2017 09:00:56 AM UTC, original submission:

To reproduce, run 'src/nano xx.c', and type:

/* Hey
hey */

The comment doesn't get colored. This is because there is no preceding line of the first line of the file, so when it redraws that line (when the */ gets typed) it looks at the current multidata. It shouldn't do that. It should never do that when redrawing. Or rather: there should be two states: 1) redraw because of scrolling, which should use current multidata; 2) redraw because of changed multiline matches, which should reevaluate things for each line that gets drawn.

Mode 2) used to get accomplished by resetting the multidata for a certain range of lines. The problem was that that wasn't good enough: the backwards resetting went too far, or didn't stop at the right places (I think), and the forwards resetting didn't go far enough, not for a symmetrical start and end.

So... for now ditch the looking at current multidata, and see if we'll implement the two different modes later.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 13 Feb 2017 06:50:44 PM UTCbensOpen/ClosedOpen=>Closed
    Mon 13 Feb 2017 09:29:41 AM UTCbensStatusIn Progress=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1