bugGNU Octave - Bugs: bug #50265, warnings for use of...

 
 

bug #50265: warnings for use of clean_up_and_exit function

Submitted by:  Rik <rik5>
Submitted on:  Thu 09 Feb 2017 05:26:56 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 01 Mar 2017 10:42:10 AM UTC, comment #7:

Just for the files: the patch of comment #6 works for me, there are no more warnings.

Kai Torben Ohlhus <siko1056>
Project Member
Sun 26 Feb 2017 09:36:20 PM UTC, comment #6:

I changed two instances of bool to int and the code now compiles without warnings. I assume that's good enough so I checked that change in under jwe's name here (http://hg.savannah.gnu.org/hgweb/octave/rev/3de5efeffb86).

Rik <rik5>
Project Administrator
Sat 25 Feb 2017 04:01:29 AM UTC, comment #5:

Yeah, oops,just change bool to int in the C interface and it should work.

John W. Eaton <jwe>
Project Administrator
Sat 25 Feb 2017 03:40:42 AM UTC, comment #4:

The patch doesn't compile for me. Apparently bool is used in a 'C' context rather than a C++ context.

Rik <rik5>
Project Administrator
Fri 24 Feb 2017 10:46:56 PM UTC, comment #3:

Since that call happens inside octave_rethrow_exception, I think it should throw an exit exception instead of just calling exit. Something like the attached patch? I added the extern "C" wrapper function for consistency. These functions allow some exceptions to be thrown from C code but I'm not sure whether we really need that or that it is useful/desirable/safe/etc.

(file #39825)

John W. Eaton <jwe>
Project Administrator
Fri 24 Feb 2017 06:28:17 PM UTC, comment #2:

I've attached a changeset which replaces the call to the deprecated function clean_up_and_exit with a direct call to exit(). JWE should probably review since I don't know if that is the right strategy.

(file #39822)

Rik <rik5>
Project Administrator
Wed 15 Feb 2017 09:07:26 AM UTC, comment #1:

Here, I get the very same warning. Maybe it is connected to cset http://hg.savannah.gnu.org/hgweb/octave/rev/9f406f0b36da .
There, jwe writes:

Maybe a line of the desired cset is missing? If jwe confirms, I can push a fix for this warning.

Kai Torben Ohlhus <siko1056>
Project Member
Thu 09 Feb 2017 05:26:56 PM UTC, original submission:

When building recent development versions of Octave I see the following warnings
:

The are all associated with a single instance of clean_up_and_exit in liboctave.

Seems pretty easy to fix, but I don't know what function now replaces clean_up_and_exit().

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #39825:  diffs.txt added by jwe (1KiB - text/plain)
file #39822:  bug_50265.cset added by rik5 (900B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by siko1056 (Posted a comment)
  • -unavailable- added by siko1056 (Author of the cset.)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 26 Feb 2017 09:36:20 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 24 Feb 2017 10:46:56 PM UTCjweAttached File-=>Added diffs.txt, #39825
    Fri 24 Feb 2017 06:28:17 PM UTCrik5Attached File-=>Added bug_50265.cset, #39822
      StatusNeed Info=>Patch Submitted
    Wed 15 Feb 2017 09:07:26 AM UTCsiko1056StatusNone=>Need Info
      Carbon-Copy-=>Added jwe

    Back to the top


    Powered by Savane 3.1-cleanup1