bugGNU Octave - Bugs: bug #50180, OF-image fails to build with dev...

 
 

bug #50180: OF-image fails to build with dev Octave (4.3.0+)

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Sun Jan 29 17:30:18 2017  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: philipnienhuisOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed Mar 15 22:35:03 2017, comment #9:

> What about the patch in MXE-octave
> (http://hg.octave.org/mxe-octave/rev/74c7af6a36c0),
> should it be there after your fix?


Yes, because mxe installs the last release of a package. It wouldn't if I backported the fix into the image package stable branch and made a new release 2.6.2.

Carnë Draug <carandraug>
Project Member
Wed Mar 15 19:31:24 2017, comment #8:

Thanks, Carnë.

What about the patch in MXE-octave
(http://hg.octave.org/mxe-octave/rev/74c7af6a36c0),
should it be there after your fix?

Avinoam Kalma <avinoam>
Project Member
Wed Mar 15 17:43:25 2017, comment #7:

> I am not sure if applying this patch to OF-image would stop OF-image to work with stable Octave.


Yes it would.

---

I made a wrapper header for the core functions that change place and added a configure check. Seems to work for me, both 4.2.1 and development sources.

http://hg.code.sf.net/p/octave/image/rev/742462d332ad

I am not thinking of applying this to the stable branch since I hope that image 2.8 is out by the time 4.4 is out. I would also guess that anyone building octave from development sources should be also be building the image package from source and not installing the last release. This might be misguided so let's see if anyone complains.

Carnë Draug <carandraug>
Project Member
Sun Mar 12 20:31:03 2017, comment #6:

"it" in the second paragraph refers to the original patch (file #39964)

Philip Nienhuis <philipnienhuis>
Project Member
Sun Mar 12 20:29:23 2017, comment #5:

The namespace change that induced this bug was made on Octave's development branch, not on stable. I am not sure if applying this patch to OF-image would stop OF-image to work with stable Octave.

BTW looking at JWE's patch:
Yesterday I applied it to my local tree as well (and I can confirm of-image gets built) but I also had to register the patch in dist-files.mk to get it picked up by the build system.

Philip Nienhuis <philipnienhuis>
Project Member
Sat Mar 11 15:36:59 2017, comment #4:

This patch fixes the problem, and it was applied by JWE to
the mxe tree (http://hg.octave.org/mxe-octave/rev/74c7af6a36c0).

Shouldn't the patch by applied to the image package itself
(http://hg.code.sf.net/p/octave/image)?

Avinoam Kalma <avinoam>
Project Member
Fri Mar 10 16:17:51 2017, comment #3:

The attached patch will avoid the problem with the call to feval being ambiguous.

(file #39964)

John W. Eaton <jwe>
Project Administrator
Wed Feb 1 18:56:02 2017, comment #2:

cc'd package maintainer

Philip Nienhuis <philipnienhuis>
Project Member
Mon Jan 30 16:15:21 2017, comment #1:

Confirmed on Windows running MXE-Octave with hg_id 868daa374c49

Avinoam Kalma <avinoam>
Project Member
Sun Jan 29 17:30:18 2017, original submission:

On Linux I get:

On Windows, both while cross-building or later on when 4.3.0+ has been installed, I get similar error messages.
From the mxe-octave build log:

hg id Octave: 9241a0fa7873 tip "Additional output arguments for fminsearch (bug #44220)."

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #39964:  image-diffs.txt added by jwe (3kB - text/plain)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by philipnienhuis
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Mar 15 17:43:25 2017carandraugStatusPatch Reviewed=>Fixed
      Open/ClosedOpen=>Closed
    Sat Mar 11 15:36:59 2017avinoamStatusPatch Submitted=>Patch Reviewed
    Fri Mar 10 17:02:27 2017avinoamStatusConfirmed=>Patch Submitted
    Fri Mar 10 16:17:51 2017jweAttached File-=>Added image-diffs.txt, #39964
    Sun Mar 5 19:35:15 2017avinoamDependencies-=>bugs #50453 is dependent
    Wed Feb 1 18:56:02 2017philipnienhuisCarbon-Copy-=>Added carandraug
    Mon Jan 30 16:15:21 2017avinoamStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1