bugGNU Screen - Bugs: bug #50089, Screen 4.5.0 doesn't build on SunOS

 
 

bug #50089: Screen 4.5.0 doesn't build on SunOS

Submitted by:  None
Submitted on:  Thu 19 Jan 2017 10:06:30 AM UTC  
 
Category: Build/InstallSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Alexander Naumov <anaumov>
Open/Closed: ClosedRelease: 4.5.0
Fixed Release: 4.5.1Planned Release: 4.5.1
Work Required: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 13 Feb 2017 08:37:14 PM UTC, comment #2:

OpenIndiana x86:
root@sun:~/screen/src# uname -a
SunOS sun 5.11 illumos-2816291 i86pc i386 i86pc

root@sun:~/screen/src# cat ~/test.c
#include<stdio.h>
#include<limits.h>
int main()
{
printf("PATH_MAX = %d\n", PATH_MAX);
return 0;
}

root@sun:~/screen/src# ~/test
PATH_MAX = 1024

I added limits.h to master and screen-v4 branch:
http://git.savannah.gnu.org/cgit/screen.git/commit/?h=screen-v4&id=6994c70aa180a5617fe8fdd563b7653d0d16fa2a
http://git.savannah.gnu.org/cgit/screen.git/commit/?id=59b88a8411366d512a2db2c10c39cc9b83fcb13b

Please test it.

Alexander Naumov <anaumov>
Project AdministratorIn charge of this item.
Thu 19 Jan 2017 01:04:30 PM UTC, comment #1:

The same issue shows up in GNU Hurd, which also doesn't know PATH_MAX because it doesn't seem to need it, i.e. doesn't have a limit for a path length.

In Debian we apply this clumsy patch for GNU Hurd which sets an arbitrary limit if none is given:

https://anonscm.debian.org/cgit/collab-maint/screen.git/tree/debian/patches/61-default-PATH_MAX-if-undefined-for-hurd.patch

Of course it would be nice if this would be solved in a cleaner way for an official fix.

Axel Beckert <abe>
Thu 19 Jan 2017 10:06:30 AM UTC, original submission:

Building on illumos (SunOS 5.11) fails with:

gcc -c -I. -I. -D_XPG4_2 -D__EXTENSIONS__ -DETCSCREENRC='"/etc/screenrc"' -DSCREENENCODINGS='"/usr/share/screen/utf8encodings"' -DHAVE_CONFIG_H -DGIT_REV=\"\" \
-O screen.c
screen.c: In function 'main':
screen.c:674:43: error: 'PATH_MAX' undeclared (first use in this function)
if (strlen(screenlogfile) > PATH_MAX)

The problem is that screen.c needs to #include <limits.h> (just like tty.c does, which is the other place PATH_MAX i s used)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #39652:  screen_4.5.0_coredump.txt added by None (2KiB - text/plain - screen dumps core instantly on Solaris)
file #39650:  screen_4.5.0_hack.txt added by None (4KiB - text/plain - Make a few minor changes and then manually link other wise link stage fails)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by anaumov (Updated the item)
  • -unavailable- added by abe (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 22 Feb 2017 07:43:03 PM UTCanaumovOpen/ClosedOpen=>Closed
    Wed 22 Feb 2017 07:42:41 PM UTCanaumovStatusReady For Test=>Fixed
    Mon 13 Feb 2017 08:37:14 PM UTCanaumovStatusNone=>Ready For Test
      Release5.0.0=>4.5.0
      Fixed ReleaseNone=>4.5.1
      Planned ReleaseNone=>4.5.1
    Fri 03 Feb 2017 02:49:19 AM UTCNoneAttached File-=>Added screen_4.5.0_coredump.txt, #39652
    Thu 02 Feb 2017 10:53:31 PM UTCNoneAttached File-=>Added screen_4.5.0_hack.txt, #39650
    Fri 20 Jan 2017 09:29:44 AM UTCanaumovAssigned toNone=>anaumov

    Back to the top


    Powered by Savane 3.1-cleanup1