bugGNU Octave - Bugs: bug #50084, OF geometry: minDistancePoints...

 
 

bug #50084: OF geometry: minDistancePoints error when requesting three outputs

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Thu 19 Jan 2017 08:49:31 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Unexpected Error
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 01 Feb 2017 05:35:00 PM UTC, comment #6:

Thanks for the fix, closing report.

Philip Nienhuis <philipnienhuis>
Project Member
Wed 01 Feb 2017 01:52:12 AM UTC, comment #5:

I have fixed this issue. It was caused by faulty input argument parsing, which in turn was caused by too complicated logic.

I re-wrote the function
https://sourceforge.net/p/octave/geometry/ci/502362bc2611f143d7844461e1090095020b4ab4/

Please close this bug.

Thanks.

Juan Pablo Carbajal <juanpi>
Project Member
Mon 23 Jan 2017 09:04:08 PM UTC, comment #4:

Sorry for the delay. I will get this sorted out soon.

Juan Pablo Carbajal <juanpi>
Project Member
Mon 23 Jan 2017 08:51:47 PM UTC, comment #3:

No patch or solution was supplied, just an analysis.
JuanPi is the one who hopefully knows what the right fix should be.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 23 Jan 2017 05:41:41 PM UTC, comment #2:

Confirmation from Juan is needed. I can also mark this as patch submitted, as a possible solution is given. State none was too default after quickly reviewing this bug report.

Kai Torben Ohlhus <siko1056>
Project Member
Mon 23 Jan 2017 04:58:39 PM UTC, comment #1:

@Kai: what info is needed?

Philip Nienhuis <philipnienhuis>
Project Member
Thu 19 Jan 2017 08:49:31 AM UTC, original submission:

(OF geometry 2.1.1)

while

looks to be OK.

The bug lies in the if block at L. 186 that is skipped while in the elseif clause in L.208+ values from uninitialized variables in that skipped if block are assigned to varargout.

(package maintainer cc'd - hopefully I got his email right))

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by juanpi (Posted a comment)
  • -unavailable- added by siko1056 (Updated the item)
  • -unavailable- added by philipnienhuis (Submitted the item)
  • -unavailable- added by philipnienhuis
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 Feb 2017 05:35:00 PM UTCphilipnienhuisStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Sun 22 Jan 2017 09:46:00 PM UTCsiko1056StatusNone=>Need Info
    Thu 19 Jan 2017 08:49:31 AM UTCphilipnienhuisCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1