bugGNU nano - Bugs: bug #50006, an undo wrongly undoes two...

 
 

bug #50006: an undo wrongly undoes two separate deletes as a whole

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Sun 08 Jan 2017 09:20:33 AM UTC  
 
Severity: 5 - BlockerStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 08 Jan 2017 10:20:21 AM UTC, comment #2:

Fixed in git, 322120c9.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sun 08 Jan 2017 10:04:22 AM UTC, comment #1:

The offending commit is 1cb6619d.

Bah. I had thought that the non-continuation detection was done at the beginning of update_undo(). But that is the case only for some of the actions, or when they happen on different lines. :|

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sun 08 Jan 2017 09:20:33 AM UTC, original submission:

Since nano-2.7.3, doing two deletes on different positions in a line, and then doing an undo, will not undo the last delete, but will undo both of them in the position of the first delete.

To reproduce, run 'src/nano --ignore' and type:
one two <Home> <Del> <Ctrl+Right> <Del> M-U

Result: "otne wo"!

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Jan 2017 10:55:52 AM UTCbensOpen/ClosedOpen=>Closed
    Sun 08 Jan 2017 10:20:21 AM UTCbensStatusIn Progress=>Fixed
    Sun 08 Jan 2017 10:04:22 AM UTCbensStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1