bugGNU Octave - Bugs: bug #49973, class constructors fails on...

 
 

bug #49973: class constructors fails on multiple inheritance.

Submitted by:  None
Submitted on:  Mon 02 Jan 2017 04:52:23 PM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: Kai Torben Ohlhus <siko1056>
Originator Name: Originator Email: -unavailable-
Open/Closed: ClosedRelease: dev
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 05 Jan 2017 10:09:13 AM UTC, comment #6:

The regression test has been added to default: http://hg.savannah.gnu.org/hgweb/octave/rev/4abd1ae61a79 .

-- closing report.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Tue 03 Jan 2017 06:47:19 PM UTC, comment #5:

@Rik: Thanks for the quick fix. I know your changes happen very carefully and I take care of your suggestion of comment #4 to have some regression test for the future.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Tue 03 Jan 2017 06:15:29 PM UTC, comment #4:

I fixed the problem (forgot to increment an index in a loop) in this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/53bb781d70c0).

However, the test suite for Octave should have caught that there was a problem with multiple inheritance. Kai, could you package up the files associated with this bug report and make a new test in the test/ directory? It could be in a directory with the bug number, or in a directory named after the feature such as multiple_inheritance.

Rik <rik5>
Project Administrator
Tue 03 Jan 2017 05:40:15 PM UTC, comment #3:

I used 'hg bisect' to track the problem down to the same cset. I'll take a look.

Rik <rik5>
Project Administrator
Tue 03 Jan 2017 04:30:19 PM UTC, comment #2:

The changes in the cset shouldn't have affected anything, just replacing one syntax with another. Did you use 'hg bisect' to find that 50495eeb5df1 was the problem cset, or could it have been earlier?

Rik <rik5>
Project Administrator
Mon 02 Jan 2017 08:35:13 PM UTC, comment #1:

Thank you for the report. I can confirm this bug.

Changes on `ov-classdef.cc` [1] seem to be the problem. I simply reversed that file to the previous state and everything worked as before.

Rik, maybe you have more insight on the changes?

[1]: http://hg.savannah.gnu.org/hgweb/octave/rev/50495eeb5df1

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Mon 02 Jan 2017 04:52:23 PM UTC, original submission:

Octave runs into the error below when subclassing 2 classes.
In octave 4.0.3 and 4.2.0 (and matlab) this examples runs.

class c.m:

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #39343:  ab.m added by None (20B - application/octet-stream)
file #39344:  use_a.m added by None (103B - application/octet-stream)
file #39345:  abc.m added by None (25B - application/octet-stream)
file #39346:  b.m added by None (15B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by siko1056 (Posted a comment)
  • -unavailable- added by siko1056 (Has knowledge about cset.)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 05 Jan 2017 10:09:13 AM UTCsiko1056StatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Wed 04 Jan 2017 01:47:51 AM UTCrik5StatusPatch Submitted=>In Progress
    Tue 03 Jan 2017 06:47:19 PM UTCsiko1056StatusIn Progress=>Patch Submitted
      Assigned toNone=>siko1056
    Tue 03 Jan 2017 06:15:29 PM UTCrik5StatusConfirmed=>In Progress
    Mon 02 Jan 2017 08:35:13 PM UTCsiko1056StatusNone=>Confirmed
      Carbon-Copy-=>Added rik5
    Mon 02 Jan 2017 04:52:23 PM UTCNoneAttached File-=>Added ab.m, #39343
      Attached File-=>Added use_a.m, #39344
      Attached File-=>Added abc.m, #39345
      Attached File-=>Added b.m, #39346

    Back to the top


    Powered by Savane 3.1-cleanup1