bugGNU Octave - Bugs: bug #49880, Failure to install package from...

 
 

bug #49880: Failure to install package from uncompressed file

Submitted by:  Thomas <harmonic_gnu>
Submitted on:  Sun 18 Dec 2016 09:08:56 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Installation Failure
Status: DuplicateAssigned to: None
Originator Name: harmonic_gnuOpen/Closed: Closed
Release: 4.2.0Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 Dec 2016 06:25:04 PM UTC, comment #1:

This is a duplicate of bug #32839 that has been open for several years. The discussion on that bug issue seems to point to this turning into a dropped feature, rather than being fixed. But please add any comments to that discussion instead of here. I'm closing this report with duplicate status.

Mike Miller <mtmiller>
Project Administrator
Sun 18 Dec 2016 09:08:56 PM UTC, original submission:

Symptom:
Octave is supposed to support installing a package from a file that is already uncompressed into a directory. However when trying to install the package from a directory it gives the following error:

unpack: FILETYPE must be "gunzip" for a directory
error: called from
install at line 146 column 5
pkg at line 394 column 9

A directory is not supposed to be gunzipped, so this suggests something is wrong.

The Cause:

In lines 65 & 99 of install.m a verification of whether its a directory or a compressed file is done by using the "exist()" function:

The use of the exist function here is not correct because (exist (tgz, "file") will give 0 only if tgz is not a file AND not a directory, the function does not give a binary output. If it is either of them the output is 2 or 7, which evaluate to true in the if statement.

Suggested correction:

For line 65 it should say instead
, meaning that if tgz exists and is a file then execute that piece to decompress it.
For line 99 we could have:

which would execute that piece of the code only if a valid file or directory were found.

Thomas <harmonic_gnu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #39275:  varadhya_diff_fixes_#49880 added by varadhya (765B - application/octet-stream - Hi Thomas, I feel the same too. I have submitted a diff file here after making those particular changes. Can you have a look at it?)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by varadhya (Updated the item)
  • -unavailable- added by harmonic_gnu (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 Dec 2016 06:25:04 PM UTCmtmillerStatusNone=>Duplicate
      Open/ClosedOpen=>Closed
      Dependencies-=>Depends on bugs #32839
    Sun 18 Dec 2016 11:31:53 PM UTCvaradhyaAttached File-=>Added varadhya_diff_fixes_#49880, #39275

    Back to the top


    Powered by Savane 3.1-cleanup1