bugGNU nano - Bugs: bug #49840, in softwrap mode, when searching...

 
 

bug #49840: in softwrap mode, when searching for strings/brackets, current_y isn't properly restored

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Wed 14 Dec 2016 06:27:01 AM UTC  
 
Severity: 3 - NormalStatus: Works For Me
Assigned to: NoneOpen/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 08 Jan 2017 02:31:23 PM UTC, comment #2:

Those settings of current_y have been removed as they were irrelevant.

Closing, as there was not actual unwanted behavior.

Benno Schulenberg <bens>
Project Administrator
Wed 14 Dec 2016 06:46:38 PM UTC, comment #1:

But does the lack of recalculation cause a problem? Because as soon as searching is over (something was found), control returns to the main loop, which calls reset_cursor() (either directly or through edit_refresh()), which recalculates current_y. So... in most cases, keeping track of current_y is superfluous.

If in this case it /does/ cause a problem, please report the actual bug first -- in this very bug number will do.

Benno Schulenberg <bens>
Project Administrator
Wed 14 Dec 2016 06:27:01 AM UTC, original submission:

In current git, in findnextstr() and find_bracket_match(), the code to restore openfile->current_y after searching doesn't properly account for softwrapped lines.

The attached patch fixes this.

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Jan 2017 02:31:23 PM UTCbensStatusNone=>Works For Me
      Open/ClosedOpen=>Closed
    Wed 14 Dec 2016 06:27:01 AM UTCdolorousAttached File-=>Added 0001-search-properly-restore-openfile-current_y-in-softwr.patch, #39219

    Back to the top


    Powered by Savane 3.1-cleanup1