bugGNU nano - Bugs: bug #49803, compute_maxrows() unnecessarily...

 
 

bug #49803: compute_maxrows() unnecessarily includes softwrap code in tiny mode

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Thu 08 Dec 2016 04:19:09 PM UTC  
 
Severity: 2 - MinorStatus: Fixed
Assigned to: David Lawrence Ramsey <dolorous>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 09 Dec 2016 12:38:45 PM UTC, comment #1:

Applied to git, in c8c6340c. Thanks for the patch.

Benno Schulenberg <bens>
Project Administrator
Thu 08 Dec 2016 04:19:09 PM UTC, original submission:

compute_maxrows() always sets maxrows to editwinrows when softwrap mode is off, but code that it uses when softwrapping is on is still included when NANO_TINY is defined.

Since NANO_TINY disables softwrapping mode entirely, all softwrapping code here should be moved behind NANO_TINY #ifdefs. The attached patch against current git does this.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 13 Dec 2016 11:49:50 AM UTCbensOpen/ClosedOpen=>Closed
    Fri 09 Dec 2016 12:38:45 PM UTCbensSeverity3 - Normal=>2 - Minor
      StatusNone=>Fixed
      Assigned toNone=>dolorous
    Thu 08 Dec 2016 04:19:09 PM UTCdolorousAttached File-=>Added 0001-Put-all-softwrap-specific-code-in-compute_maxrows-be.patch, #39176

    Back to the top


    Powered by Savane 3.1-cleanup1