bugGNU Octave - Bugs: bug #49760, gzip fails on certain files

 
 

bug #49760: gzip fails on certain files

Submitter:  Marcus <mclopez>
Submitted:  Sat 03 Dec 2016 03:43:49 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Marcus Open/Closed:  * Closed
Release:  * 4.2.0 Operating System:  * Mac OS
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 18 Dec 2016 03:10:56 PM UTC, comment #4: 

Changed on the stable branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/b150be19734d).  This will be a part of the 4.2.1 bug fix release.  Closing report.

Rik <rik5>
Group administrator
Sun 18 Dec 2016 12:42:35 AM UTC, comment #3: 

I am perfectly content to remain anonymous.
Thank you for asking.

Marcus <mclopez>
Wed 14 Dec 2016 09:18:30 PM UTC, comment #2: 

@Marcus: We generally try to credit people who contribute to Octave.  Would you like to turn this into a full changeset and be acknowledged on the Contributors page in the introductory chapter of the Octave manual?  Others prefer to remain anonymous, in which case I will make it a complete changeset and check it in under my credentials.

Rik <rik5>
Group administrator
Fri 09 Dec 2016 06:55:26 PM UTC, comment #1: 

We hit this big time in Fedora.  No octave packages would build due to problems compressing the tar files.  Errors would occur on different architectures on different packages - but would be consistent.  The attached patch fixed it for us.  I'd classify this has a high priority issue that suggest an immediate 4.2.1 release.

Orion Poplawski <opoplawski>
Sat 03 Dec 2016 03:43:49 PM UTC, original submission:  

gzip fails to compress certain tar files.
In gzip.cc, deflateEnd returns Z_DATA_ERROR instead of Z_OK.
By changing the deflate function to more closely match the zlib example, the error went away.
Attached is a possible patch and a tar file that fails.
As I am using macOS, the tar file was created with bsdtar instead of gnutar.

Marcus <mclopez>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39137:  optics-0.1.3-any-none.tar added by mclopez (264KiB - application/x-tar)
file #39136:  patch.diff added by mclopez (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by opoplawski (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by mclopez (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-12-18 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2016-12-05 siko1056 StatusNone Patch Submitted
    2016-12-03 mclopez Attached File- Added patch.diff, #39136
        Attached File- Added optics-0.1.3-any-none.tar, #39137

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code