bugGNU nano - Bugs: bug #49713, missing ChangeLog entries

 
 

bug #49713: missing ChangeLog entries

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Sat 26 Nov 2016 11:06:37 PM UTC  
 
Severity: 4 - ImportantStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 11 Jan 2017 10:59:00 AM UTC, comment #5:

Considering this fixed by commit 121c53f3. If you don't think it is good enough, pleas reopen.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 29 Nov 2016 05:05:48 PM UTC, comment #4:

Okay.

Good to know on how to use git log that way; thanks.

David Lawrence Ramsey <dolorous>
Project Administrator
Tue 29 Nov 2016 04:54:44 PM UTC, comment #3:

So... we will first need the machinery for generating a Changelog from git commit messages. Grep has script for that and a build target, but... I don't like the way the resulting Changelog looks. Hrrrm. And it's silly that I still have to specify which files and fucntions were changed: git knows these things. Pfff. Don't know what to do with this.

By the way, for looking at how a certain function has changed over time, git log -L colon funcname colon filename is useful. In this case:

git log -L :no_current_file_name_warning:src/nano.c

That's quite a bit better than a changelog, in my opinion.

(You'll first have to make a checkout where that function still exists, though: d48071b, for example.)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sun 27 Nov 2016 09:16:42 PM UTC, comment #2:

Okay. And understood on hating to write changelog entries with every change. I only noticed when I was trying to look up when no_current_file_name_warning() was changed.

Sounds like the right approach. Although, to save some time, some of the short blurbs you begin commit messages with could probably work for changelog entries, although with function names added. So it won't be as huge as, say, some parts of the pre-2.1 changelog :)

David Lawrence Ramsey <dolorous>
Project Administrator
Sun 27 Nov 2016 07:45:18 PM UTC, comment #1:

Yes... I thought I would start to write the git commit messages in such a way that an acceptable Changelog could be automatically generated from them. But I never started doing that. And then let it be. :|

What shall we do? Write the missing part of the Changelog now, far after the fact? And when it's done, start adding a Changelog entry with every commit? I kind of hate the latter: almost every commit touching the Changelog. I want each commit to touch only the files that it actually effectively changes. So... I guess I will have to start writing commit messages in a manner that can be compiled into a changelog at release time. What do you think?

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sat 26 Nov 2016 11:06:37 PM UTC, original submission:

In current nano git, the ChangeLog appears to be missing all entries past March 31, 2016 (which was approximately when nano transitioned from SVN to git).

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Jan 2017 10:59:00 AM UTCbensStatusNone=>Fixed
      Assigned toNone=>bens
      Open/ClosedOpen=>Closed
    Sun 27 Nov 2016 07:45:18 PM UTCbensSummaryMissing ChangeLog entries=>missing ChangeLog entries
    Sun 27 Nov 2016 07:45:17 PM UTCbensSeverity3 - Normal=>4 - Important

    Back to the top


    Powered by Savane 3.1-cleanup1