bugGNU Octave - Bugs: bug #49492, gl2ps buffer size should be sized...

 
 

bug #49492: gl2ps buffer size should be sized only once when producing Latex output

Submitted by:  Rik <rik5>
Submitted on:  Mon 31 Oct 2016 07:33:54 PM UTC  
 
Category: PerformanceSeverity: 2 - Minor
Priority: 3 - LowItem Group: Performance
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 13 Nov 2016 02:17:33 PM UTC, comment #2:

The patch didn't compile, but I removed an unnecessary '=' sign and then it worked. I checked it in here (http://hg.savannah.gnu.org/hgweb/octave/rev/50fa2d656326).

Fixed, closing report.

Rik <rik5>
Project Administrator
Fri 11 Nov 2016 06:32:54 PM UTC, comment #1:

I attached a patch.

(file #38936)

Pantxo Diribarne <pantxo>
Project Member
Mon 31 Oct 2016 07:33:54 PM UTC, original submission:

The sequence to produce output for Latex involves calling gl2ps_renderer::draw twice. See this comment in gl2ps-print.cc:

If the plot to print is very complicated, the gl2ps buffer may overflow in which case Octave has to retry with a larger buffer size. This is fine, but after the first drawnow(), the correct buffer size is known and it shouldn't be necessary to go through the time consuming step of sizing the buffer again.

Code which produces problem:

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38936:  buffsize.patch added by pantxo (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pantxo (Updated the item)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 13 Nov 2016 02:17:33 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 11 Nov 2016 06:32:54 PM UTCpantxoAttached File-=>Added buffsize.patch, #38936
      StatusNone=>Patch Submitted
    Mon 07 Nov 2016 07:15:34 PM UTCrik5Priority5 - Normal=>3 - Low

    Back to the top


    Powered by Savane 3.1-cleanup1