bugKawa - Bugs: bug #49475, make-temporary-file does not...

 
 

bug #49475: make-temporary-file does not interpret ~d properly

Submitted by:  Sudarshan S Chawathe <chaw>
Submitted on:  Sat 29 Oct 2016 07:40:14 PM UTC  
 
Category: Scheme languageSeverity: 3 - Normal
Item Group: Unexpected resultStatus: Fixed
Privacy: PublicAssigned to: Per Bothner <bothner>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 30 Oct 2016 12:52:10 PM UTC, comment #2:

Just a quick note to confirm that it now works for me too after updating to SVN revision 9004. Thanks!

Sudarshan S Chawathe <chaw>
Sun 30 Oct 2016 02:13:54 AM UTC, comment #1:

Thanks. Fixed.

Per Bothner <bothner>
Project AdministratorIn charge of this item.
Sat 29 Oct 2016 07:40:14 PM UTC, original submission:

I believe there is a small bug in kawa/lib/files.scm which results in the ~d in a template such as "kawa~d.tmp" not being replaced by a suitable string (which I assume is the intention).

From what I can tell based on a quick look, changing #\~ to "~" in an indexOf invocation (in the make-temporary-file procedure) fixes things (context diff also attached):

$ diff kawa/lib/files.scm~ kawa/lib/files.scm
164c164
< (tilde (fmt:indexOf #\~))
---

> (tilde (fmt:indexOf "~"))


I guess adding an explicit type specifier may be a better fix, but the above seems to do the trick.

All the above is using a SVN version of Kawa from earlier today:

$ kawa --version
Kawa 2.1.9 (revision 8992M)
Copyright (C) 2016 Per Bothner

Sudarshan S Chawathe <chaw>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bothner (Posted a comment)
  • -unavailable- added by chaw (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Oct 2016 03:18:16 PM UTCbothnerOpen/ClosedOpen=>Closed
    Sun 30 Oct 2016 02:13:54 AM UTCbothnerStatusNone=>Fixed
      Assigned toNone=>bothner
    Sat 29 Oct 2016 07:40:14 PM UTCchawAttached File-=>Added make-temporary-file-format.diff, #38840

    Back to the top


    Powered by Savane 3.1-cleanup1