bugGNU Astronomy Utilities - Bugs: bug #49460, When check linking fails, the...


You are not allowed to post comments on this tracker with your current authentication level.

bug #49460: When check linking fails, the successful checks message should not be printed

Submitter:  Mohammad Akhlaghi <makhlaghi>
Submitted:  Thu 27 Oct 2016 04:47:11 PM UTC
Category:  Installation Severity:  3 - Normal
Item Group:  Crash Status:  Postponed
Privacy:  Public Assigned to:  None
Open/Closed:  Open

Fri 28 Oct 2016 08:20:38 AM UTC, comment #2: 

Sorry, the previous comment was a mistake, it should have been done on bug #49459!

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Fri 28 Oct 2016 08:19:23 AM UTC, comment #1: 

The problem is now fixed and pushed to the main repo. The problem was that I thought `AC_FUNC_MALLOC' is included by Gnulib, so after a check, I saw it isn't and we have to call it ourselves.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Thu 27 Oct 2016 04:47:11 PM UTC, original submission:  

The checks also include compiling programs with Gnuastro's library and running them. However, when there is an error in the creation of the executable (linking in the example below), the message that all tests have passed is apparently still printed.

The example below is related to bug #49459, kindly reported by Antonio Diaz Diaz.

In such cases that message should not be printed.

make[2]: Entering directory `/home/build/gnuastro-0.2/tests'
make  versioncpp arraymanip multithread
make[3]: Entering directory `/home/build/gnuastro-0.2/tests'
depbase=`echo lib/versioncpp.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
g++ -DHAVE_CONFIG_H -I. -I..  -I../lib -DSYSCONFIG_DIR=\"/usr/local/etc\" -I../lib   -g -O2 -MT lib/versioncpp.o -MD -MP -MF $depbase.Tpo -c -o lib/versioncpp.o lib/versioncpp.cpp &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool  --tag=CXX   --mode=link g++  -g -O2  -L../lib  -pthread -o versioncpp lib/versioncpp.o -lgnuastro -ljpeg -lwcs -lcfitsio -lgsl -lgslcblas -lm
libtool: link: g++ -g -O2 -pthread -o .libs/versioncpp lib/versioncpp.o  -L../lib /home/build/gnuastro-0.2/lib/.libs/libgnuastro.so /usr/lib64/libjpeg.so -lwcs -lcfitsio -lgsl -lgslcblas -lm -pthread -Wl,-rpath -Wl,/usr/lib64
/home/build/gnuastro-0.2/lib/.libs/libgnuastro.so: undefined reference to `rpl_malloc'
collect2: error: ld returned 1 exit status
make[3]: *** [versioncpp] Error 1
depbase=`echo lib/arraymanip.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -DSYSCONFIG_DIR=\"/usr/local/etc\" -I../lib   -Wall -O3  -pthread -MT lib/arraymanip.o -MD -MP -MF $depbase.Tpo -c -o lib/arraymanip.o lib/arraymanip.c &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -Wall -O3  -pthread  -L../lib  -pthread -o arraymanip lib/arraymanip.o -lgnuastro -ljpeg -lwcs -lcfitsio -lgsl -lgslcblas -lm
libtool: link: gcc -Wall -O3 -pthread -pthread -o .libs/arraymanip lib/arraymanip.o  -L../lib /home/build/gnuastro-0.2/lib/.libs/libgnuastro.so /usr/lib64/libjpeg.so -lwcs -lcfitsio -lgsl -lgslcblas -lm -pthread -Wl,-rpath -Wl,/usr/lib64
/home/build/gnuastro-0.2/lib/.libs/libgnuastro.so: undefined reference to `rpl_malloc'
collect2: error: ld returned 1 exit status
make[3]: *** [arraymanip] Error 1
depbase=`echo lib/multithread.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -DSYSCONFIG_DIR=\"/usr/local/etc\" -I../lib   -Wall -O3  -pthread -MT lib/multithread.o -MD -MP -MF $depbase.Tpo -c -o lib/multithread.o lib/multithread.c &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -Wall -O3  -pthread  -L../lib  -pthread -o multithread lib/multithread.o -lgnuastro -ljpeg -lwcs -lcfitsio -lgsl -lgslcblas -lm
libtool: link: gcc -Wall -O3 -pthread -pthread -o .libs/multithread lib/multithread.o  -L../lib /home/build/gnuastro-0.2/lib/.libs/libgnuastro.so /usr/lib64/libjpeg.so -lwcs -lcfitsio -lgsl -lgslcblas -lm -pthread -Wl,-rpath -Wl,/usr/lib64
/home/build/gnuastro-0.2/lib/.libs/libgnuastro.so: undefined reference to `rpl_malloc'
collect2: error: ld returned 1 exit status
make[3]: *** [multithread] Error 1
make[3]: Leaving directory `/home/build/gnuastro-0.2/tests'
make[2]: *** [check-am] Error 2
make[2]: Target `check' not remade because of errors.
make[2]: Leaving directory `/home/build/gnuastro-0.2/tests'
make[2]: Entering directory `/home/build/gnuastro-0.2'
make  check-local
make[3]: Entering directory `/home/build/gnuastro-0.2'

Your build of Gnuastro 0.2 didn't fail on any tests.
To install Gnuastro, please run the commands below:

(NOTE: As the user antonio, you don't have writing permissions
in "/usr/local". To install Gnuastro there, you must get
privileges first, as described below. If you can't, configure
Gnuastro again, for example: "./configure --prefix ~/.local".)

    sudo make install
    make install

(The following "Leaving directory" notices can be ignored.)

make[3]: Leaving directory `/home/build/gnuastro-0.2'
make[2]: Leaving directory `/home/build/gnuastro-0.2'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/build/gnuastro-0.2'
make: *** [check] Error 2

Mohammad Akhlaghi <makhlaghi>
Project Administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.




    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-10-28 makhlaghi StatusFixed Postponed
        Assigned tomakhlaghi None
        Open/ClosedClosed Open
    2016-10-28 makhlaghi StatusPostponed Fixed
        Assigned toNone makhlaghi
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.9