bugGNU Octave - Bugs: bug #49391, test_ncarray fails

 
 

bug #49391: test_ncarray fails

Submitted by:  None
Submitted on:  Thu 20 Oct 2016 09:30:16 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: CBOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 4.2.0
Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 29 Nov 2016 02:45:53 PM UTC, comment #10:

Thanks, I applied the changes:
https://github.com/Alexander-Barth/octave-ncarray

and released version 1.0.4 with these changes:

https://sourceforge.net/p/octave/package-releases/286/

Alexander Barth <abarth>
Tue 22 Nov 2016 12:47:35 PM UTC, comment #9:

Patch attached

(file #39045)

John Donoghue <lostbard>
Project Member
Mon 21 Nov 2016 09:39:38 PM UTC, comment #8:

actually added after line 57, so it is:

John Donoghue <lostbard>
Project Member
Mon 21 Nov 2016 06:04:24 PM UTC, comment #7:

gunzip is in the path however there is an issue with octave seeing non extensioned bash script files

I can get around that by making a .bat wrapper around the command.

Next issue from comment #5 is the fname in cached_decompress being path with the file part containing ':' and '\'.

If I change cached_decompress.m after line 56 to include this:

I then get the All tests passed.

John Donoghue <lostbard>
Project Member
Mon 21 Nov 2016 10:12:04 AM UTC, comment #6:

Thank you for testing and your feed-back.
I compare now the checking up to a given tolerance as you suggested.
(I used a slightly different approach to be compatibly with matlab).

The code is available here if you want to try:
https://github.com/Alexander-Barth/octave-ncarray

You can run octave directly from the inst directory to test it.

Do you have gunzip installed and in your PATH on windows?

Alexander Barth <abarth>
Wed 09 Nov 2016 12:37:57 PM UTC, comment #5:

The invalid C:\Users\JOHN\AppData\Local\Temp\oct-fzmqnN\C:\Users\JOHN\AppData\Local\Temp\oct-qKrr56\oct-Hg21CT.gz is coming from cached_decompress.m, line 57 - 61.

John Donoghue <lostbard>
Project Member
Tue 08 Nov 2016 10:10:54 PM UTC, comment #4:

Similar issue at line 97, 109, 113, 126, 130, 134, 138, 142, 146

and then (on mine at least):

John Donoghue <lostbard>
Project Member
Tue 08 Nov 2016 10:00:33 PM UTC, comment #3:

Looks like tolerance issues in windows, 4.2.0-rc3.

Changing assert (isequaln (nanmeanSST, nanmeanSSTref)) to

assert(nanmeanSST, nanmeanSSTref)

John Donoghue <lostbard>
Project Member
Tue 08 Nov 2016 03:08:40 PM UTC, comment #2:

I cannot reproduce this error on my system (Ubuntu 14.04, 64bit), neither with octave 4.2.0-rc2 nor with 4.2.0-rc3. Can you look with the debugger why this test fails?

$ octave --no-init-file
GNU Octave, version 4.2.0-rc2
Copyright (C) 2016 John W. Eaton and others.
This is free software; see the source code for copying conditions.
There is ABSOLUTELY NO WARRANTY; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE. For details, type 'warranty'.

Octave was configured for "x86_64-pc-linux-gnu".

Additional information about Octave is available at http://www.octave.org.

Please contribute if you find this software useful.
For more information, visit http://www.octave.org/get-involved.html

Read http://www.octave.org/bugs.html to learn how to submit bug reports.
For information about changes from previous versions, type 'news'.

octave:1> pkg load ncarray
octave:2> pkg list
Package Name | Version | Installation directory
--------------+---------+-----------------------
io *| 2.4.4 | /home/abarth/local/gcc-4.8.4/share/octave/packages/io-2.4.4
ncarray *| 1.0.3 | /home/abarth/local/gcc-4.8.4/share/octave/packages/ncarray-1.0.3
netcdf *| 1.0.11 | /home/abarth/local/gcc-4.8.4/share/octave/packages/netcdf-1.0.11
statistics *| 1.3.0 | /home/abarth/local/gcc-4.8.4/share/octave/packages/statistics-1.3.0
octave:3> test_ncarray
creating directory /tmp/oct-VZYKpw for temporary files.

All tests passed.
octave:4> version
ans = 4.2.0-rc2

$ octave --no-init-file
GNU Octave, version 4.2.0-rc3
Copyright (C) 2016 John W. Eaton and others.
This is free software; see the source code for copying conditions.
There is ABSOLUTELY NO WARRANTY; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE. For details, type 'warranty'.

Octave was configured for "x86_64-pc-linux-gnu".

Additional information about Octave is available at http://www.octave.org.

Please contribute if you find this software useful.
For more information, visit http://www.octave.org/get-involved.html

Read http://www.octave.org/bugs.html to learn how to submit bug reports.
For information about changes from previous versions, type 'news'.

octave:1> pkg load ncarray
octave:2> pkg list
Package Name | Version | Installation directory
--------------+---------+-----------------------
io *| 2.4.4 | /home/abarth/opt/octave-4.2.0-rc3/share/octave/packages/io-2.4.4
ncarray *| 1.0.3 | /home/abarth/opt/octave-4.2.0-rc3/share/octave/packages/ncarray-1.0.3
netcdf *| 1.0.11 | /home/abarth/opt/octave-4.2.0-rc3/share/octave/packages/netcdf-1.0.11
statistics *| 1.3.0 | /home/abarth/opt/octave-4.2.0-rc3/share/octave/packages/statistics-1.3.0
octave:3> test_ncarray
creating directory /tmp/oct-GZfGg1 for temporary files.

All tests passed.
octave:4> version
ans = 4.2.0-rc3

Alexander Barth <abarth>
Thu 20 Oct 2016 04:53:45 PM UTC, comment #1:

Does the same thing in Windows Octave 4.2.0rc2 with ncarray 1.0.3

John Donoghue <lostbard>
Project Member
Thu 20 Oct 2016 09:30:16 AM UTC, original submission:

>> pkg load ncarray
>> test_ncarray

creating directory /tmp/oct-DNxzC7 for temporary files.
error: assert (isequaln (nanmeanSST, nanmeanSSTref)) failed
error: called from
assert at line 92 column 11
test_ncarray at line 89 column 1

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by abarth (Posted a comment)
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by lostbard
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 29 Nov 2016 05:08:53 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Tue 22 Nov 2016 12:47:35 PM UTClostbardAttached File-=>Added 0001-check-for-special-windows-characters-in-cached_decom.patch, #39045
      StatusNone=>Patch Submitted
      Release4.0.0=>4.2.0
    Thu 20 Oct 2016 04:53:45 PM UTClostbardCarbon-Copy-=>Added abarth

    Back to the top


    Powered by Savane 3.1-cleanup1