bugGNU Screen - Bugs: bug #49377, [PATCH] Begin viewing scrollback...

 
 

bug #49377: [PATCH] Begin viewing scrollback buffer at the first line of output instead of at the start of the scrollback buffer

Submitted by:  Guo Ci <guoci>
Submitted on:  Mon 17 Oct 2016 10:28:14 PM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Amadeusz Sławiński <amade>
Open/Closed: ClosedRelease: Cur Dev Sources
Fixed Release: 4.6.0Planned Release: 4.6.0
Work Required: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 22 Jun 2017 09:04:35 AM UTC, comment #1:

Thanks for patch!
Applied it both to screen-v4 and master.

Amadeusz Sławiński <amade>
Project AdministratorIn charge of this item.
Mon 17 Oct 2016 10:28:14 PM UTC, original submission:

This issue has been discussed before: https://bbs.archlinux.org/viewtopic.php?id=108640

Copy mode and “hardcopy -h” always begin at the start of the scrollback buffer. If a user sets a large scrollback limit with little output, then copy mode and the file written by “hardcopy -h” will begin with many blank lines before the first line of output.

The attached patch limits the scrollback buffer traversal to begin at the first line of output, instead of the beginning of the scrollback buffer.

Also, code for moving to %age of buffer is changed to use float division so that two different rep_cnt will not jump to the same location, except for buffers less than 100 lines. Previously, the computed line number is rounded down to the nearest 100th due to integer division.

Guo Ci <guoci>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38748:  scrollback_fix.patch added by guoci (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by amade (Posted a comment)
  • -unavailable- added by guoci (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 29 Jun 2017 10:15:03 AM UTCamadeOpen/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.6.0
    Thu 22 Jun 2017 09:04:35 AM UTCamadeStatusNone=>Fixed
      Assigned toNone=>amade
      Planned ReleaseNone=>4.6.0
    Mon 17 Oct 2016 10:28:14 PM UTCguociAttached File-=>Added scrollback_fix.patch, #38748

    Back to the top


    Powered by Savane 3.1-cleanup1