bugGNU Screen - Bugs: bug #49377, [PATCH] Begin viewing scrollback...

 
 

bug #49377: [PATCH] Begin viewing scrollback buffer at the first line of output instead of at the start of the scrollback buffer

Submitter:  Guo Ci <guoci>
Submitted:  Mon 17 Oct 2016 10:28:14 PM UTC
   
 
Category:  User Interface Severity:  3 - Normal
Priority:  * 5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  amade
Open/Closed:  Closed Release:  Cur Dev Sources
Fixed Release:  4.6.0 Planned Release:  4.6.0
Work Required:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 22 Jun 2017 09:04:35 AM UTC, comment #1: 

Thanks for patch!
Applied it both to screen-v4 and master.

Amadeusz Sławiński <amade>
Group administrator
Mon 17 Oct 2016 10:28:14 PM UTC, original submission:  

This issue has been discussed before: https://bbs.archlinux.org/viewtopic.php?id=108640

Copy mode and “hardcopy -h” always begin at the start of the scrollback buffer. If a user sets a large scrollback limit with little output, then copy mode and the file written by “hardcopy -h” will begin with many blank lines before the first line of output.

The attached patch limits the scrollback buffer traversal to begin at the first line of output, instead of the beginning of the scrollback buffer.

Also, code for moving to %age of buffer is changed to use float division so that two different rep_cnt will not jump to the same location, except for buffers less than 100 lines. Previously, the computed line number is rounded down to the nearest 100th due to integer division.

Guo Ci <guoci>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #38748:  scrollback_fix.patch added by guoci (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by amade (Posted a comment)
  • -email is unavailable- added by guoci (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-29 amade Open/ClosedOpen Closed
        Fixed ReleaseNone 4.6.0
    2017-06-22 amade StatusNone Fixed
        Assigned toNone amade
        Planned ReleaseNone 4.6.0
    2016-10-17 guoci Attached File- Added scrollback_fix.patch, #38748

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code