bugGNU Screen - Bugs: bug #49336, [PATCH] Remove unnecessary...


bug #49336: [PATCH] Remove unnecessary decrement of rep_cnt

Submitted by:  Guo Ci <guoci>
Submitted on:  Thu 13 Oct 2016 03:19:20 PM UTC  
Category:  User Interface Severity:  3 - Normal
Priority:  5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  Cur Dev Sources
Fixed Release:  4.5.0 Planned Release:  None
Work Required:  None

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Sun 16 Oct 2016 02:39:56 PM UTC, comment #1: 

Thanks, pushed to screen-v4 and master branches.

Amadeusz Sławiński <amade>
Project Administrator
Thu 13 Oct 2016 03:19:20 PM UTC, original submission:  

Currently, 0% and 1% points to the same location in the scrollback buffer due to this bug.

$ git diff HEAD~
diff --git a/src/mark.c b/src/mark.c
index 04d1ecc..34b2e17 100644
--- a/src/mark.c
+++ b/src/mark.c
@@ -681,7 +681,6 @@ static void MarkProcess(char **inbufp, size_t *inlenp)
                        /* it may be useful to have a key that does nothing */
                case '%':
-                       rep_cnt--;
                        /* rep_cnt is a percentage for the history buffer */
                        if (rep_cnt < 0)
                                rep_cnt = 0;

Guo Ci <guoci>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #38719:  fix_rep_cnt.patch added by guoci (528B - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by amade (Posted a comment)
  • -email is unavailable- added by guoci (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-18 amade Open/ClosedOpen => Closed
    2017-01-18 amade Fixed ReleaseNone => 4.5.0
    2016-10-16 amade StatusNone => Fixed
    2016-10-13 guoci Attached File- => Added fix_rep_cnt.patch, #38719

    Back to the top

    Powered by Savane 3.6