bugGNU Octave - Bugs: bug #49310, -tst files for C++ code are not...

 
 

bug #49310: -tst files for C++ code are not updated when file changes

Submitted by:  Rik <rik5>
Submitted on:  Tue 11 Oct 2016 04:59:36 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 11 Oct 2016 06:14:48 PM UTC, comment #3:

I don't think the change needs to be reverted. Before I made the change I looked but couldn't see how the -tst files appeared as targets. Now I see it, but it is a bit obscure and I had to look at the generated Makefile. At least now it is a bit more explicit and I don't think the duplication hurts anything.

Yes, removing all the tests from a file will leave the old -tst file behind because we only generate -tst files for corresponding sources which contain tests.

John W. Eaton <jwe>
Project Administrator
Tue 11 Oct 2016 05:58:14 PM UTC, comment #2:

Actually, this may have been a corner case. I happened to remove the last test in ov-range.cc. I think Octave became confused because there were no tests in the file and so ov-range.cc-tst was left alone.

I just added an 'assert (0)' to oct-map.cc and the corresponding -tst file was re-generated correctly on 'make check'. This is on the development branch where your cset has not been applied.

I don't know if it is worth reversing your cset since maybe it is the right thing to be doing anyways.

Rik <rik5>
Project Administrator
Tue 11 Oct 2016 05:32:48 PM UTC, comment #1:

I checked in the following changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/78b3c48be3e6

Previously I think these files were only built/updated when running make dist.

John W. Eaton <jwe>
Project Administrator
Tue 11 Oct 2016 04:59:36 PM UTC, original submission:

I just changed the file ov-range.cc to remove the deprecated function allow_noninteger_range_as_index. After making the change and building Octave I used 'make check' to verify that everything was working correctly. The check failed due to a test in ov-range.cc-tst which was leftover. When I checked the timestamp on the -tst file it was from 7 days ago, but it had not been rebuild despite the fact that I had updated the base file ov-range.cc

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 11 Oct 2016 05:32:48 PM UTCjweStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1