bugGNU arch -- a revision control system - Bugs: bug #4920, tla buildcfg without default...

 
 

bug #4920: tla buildcfg without default archive

Submitted by:  Tom Lord <tomlord>
Submitted on:  Fri 22 Aug 2003 05:02:11 PM UTC  
 
Category: tlaSeverity: 3 - Normal
Item Group: small feature ideaStatus: Fixed
Privacy: PublicOpen/Closed: Closed
Release: 
Fixed Release: tla-1.1pre6, tla--devo--1.1--patch-146
Merge Request?: yes -- merge from my archive
Your Archive Name: robin.farine@terminus.org--arch-2003
Your Archive Location: http://213.200.230.54/{pubarch.v2}/robin.farine@terminus.org--arch/2003
Assigned to: Tom Lord <tomlord>

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 28 Aug 2003 01:52:17 AM UTC, comment #2:

I can't merge the changes to arch_build_config.

In particular, the method of computing the default
archive is no good. For example, if the config
is well written (uses fully qualified names) then
no default archive is needed -- but with your changes,
the command will exit with an error if no tree-version
is set.

Will you please rewrite these changes to accept a
default version as a parameter to arch_build_config,
and pass that parameter from cmd-buildcfg.c?

Tom Lord <tomlord>
Project MemberIn charge of this item.
Wed 27 Aug 2003 10:20:24 PM UTC, comment #1:

This archive contains the changesets related to bugs #4920 and #4942:

robin.farine@terminus.org--arch-2003
tla
tla--rnf
tla--rnf--1.1

base-0
tag of lord@emf.net--2003b/tla--devo--1.1--patch-106

patch-1
buildcfg gets its default archive from the project tree

patch-2
honor nested trees tagging methods & regexps during inventory

--
rnf

Tom Lord <tomlord>
Project MemberIn charge of this item.
Fri 22 Aug 2003 05:02:11 PM UTC, original submission:

From: Robin Farine <robin.farine@terminus.org>

First, sorry for writing this directly to you but I still don't have a
publicly accessible machine where to put an archive mirror, and since
I'm attaching a patch, posting to the mailing-list sounds like a bad
idea.

Ok, here we go. Without a default archive, I'm not able to build an arch
configuration with tla buildcfg, tla version:

lord@emf.net--2003b/dists--devo--1.0--patch-35(emf.net/devo)

The attached patch modifies arch_build_config() to explicitely pass a -A
option to getrev using the archive name obtained from
arch_try_tree_version().

Moreover, this behavior seems more correct to me than building a config
without explicit archive names using the user's default archive, YMMV.
I'm thinking of the case where one does:

tla get -A <archive> <revision> <dir>
tla buildcfg <conf>

with <archive> different from one's default archive.

--rnf

--=-y53bmLWS/yA3RzGnHoaX
Content-Disposition: attachment; filename=tla-1.1-configs.diff
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; name=tla-1.1-configs.diff; charset=ISO-8859-1

--- libarch/configs.c~ Mon Jul 14 21:46:23 2003
+++ libarch/configs.c Wed Jul 16 16:54:20 2003
@@ -279,6 +279,7 @@
arch_build_config (t_uchar * tree_root, t_uchar * config_name, int no_pris=
tines, int release_id)
{
rel_table config =3D 0;
+ t_uchar * default_archive =3D 0;
int x;
=20
config =3D arch_read_config (tree_root, config_name);
@@ -318,6 +319,13 @@
lim_free (0, saved_path);
}
=20
+ { /* get the default archive from {arch}/++default-version */
+ t_uchar * tree_version =3D arch_try_tree_version ("build-config");
+
+ default_archive =3D arch_parse_package_name (arch_ret_archive, 0, tree=
_version);
+ lim_free (0, tree_version);
+ }
+
/* build desired trees.
*/
=20
@@ -336,8 +344,8 @@
revspec =3D config[x][1];
=20
status =3D (no_pristines
- ? arch_call_cmd (arch_cmd_getrev, "getrev", "--no-pristine=
", revspec, path_to_subtree, 0)
- : arch_call_cmd (arch_cmd_getrev, "getrev", revspec, path_=
to_subtree, 0));
+ ? arch_call_cmd (arch_cmd_getrev, "getrev", "-A", default_=
archive, "--no-pristine", revspec, path_to_subtree, 0)
+ : arch_call_cmd (arch_cmd_getrev, "getrev", "-A", default_=
archive, revspec, path_to_subtree, 0));
=20
if (status)
{
@@ -390,7 +398,7 @@
lim_free (0, release_id_file);
}
=20
-
+ lim_free (0, default_archive);
rel_free_table (config);
}
=20

--=-y53bmLWS/yA3RzGnHoaX--

Tom Lord <tomlord>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 11 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 30 Aug 2003 03:45:51 AM UTCtomlordStatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)
  Fixed Release=>
Fri 29 Aug 2003 12:09:40 AM UTCtomlordOpen/ClosedFeedback=>(Error - Not Found)
Thu 28 Aug 2003 01:52:17 AM UTCtomlordOpen/ClosedOpen=>(Error - Not Found)
Thu 28 Aug 2003 01:52:16 AM UTCtomlordItem Groupbug=>(Error - Not Found)
Thu 28 Aug 2003 01:47:24 AM UTCtomlordYour Archive Namerobin.farine@terminus.org--arch-2003 =>
  Your Archive Locationhttp://213.200.230.54/{pubarch.v2}/robin.farine@terminus.org--arch/2003 =>
Wed 27 Aug 2003 10:20:24 PM UTCtomlordMerge Request?yes -- diffs included=>(Error - Not Found)
  Your Archive Name=>
  Your Archive Location=>

Back to the top


Powered by Savane 3.1-cleanup1