bugGNU Octave - Bugs: bug #48857, Incorrect indices for `union` with...

 
 

bug #48857: Incorrect indices for `union` with 'rows' flag

Submitted by:  Joakim Andén <janden>
Submitted on:  Mon 22 Aug 2016 02:23:35 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 4.0.0Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 01 Sep 2016 04:03:50 AM UTC, comment #1:

I reviewed your patch and pushed it here (http://hg.savannah.gnu.org/hgweb/octave/rev/5a3f581a314f). It will be a part of the 4.2 release which is expected in the next month.

The things I changed were using 2 spaces for indentation and wrapping long lines to less than 80 characters.

Thanks for the patch.

Rik <rik5>
Project Administrator
Mon 22 Aug 2016 02:23:35 PM UTC, original submission:

When calling `union` with the 'rows' flag, the correct set of rows is returned, but their indices within the two input arrays are not correct. Specifically, calling

we get as output

where 'ia' and 'ib' should be

I've included a changeset that fixes this and includes some tests to make sure we have the proper behavior.

Joakim Andén <janden>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38314:  union_fix.diff added by janden (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by janden (Submitted the item)
  • -unavailable- added by janden
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 01 Sep 2016 04:03:50 AM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 22 Aug 2016 02:23:35 PM UTCjandenAttached File-=>Added union_fix.diff, #38314
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1