bugGNU Octave - Bugs: bug #48828, uigetfile issues

 
 

bug #48828: uigetfile issues

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Fri 19 Aug 2016 02:59:41 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Philip Nienhuis <philipnienhuis>
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 22 Aug 2016 09:16:08 PM UTC, comment #2:

Pushed here
http://hg.savannah.gnu.org/hgweb/octave/rev/929a1500907e

closing report

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Fri 19 Aug 2016 03:04:23 PM UTC, comment #1:

Here is the cset.
If no one objects or beats me to it, I'll push it next Monday Aug. 22nd

(file #38280)

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Fri 19 Aug 2016 02:59:41 PM UTC, original submission:

Unlike Matlab, uigetfile does not allow a subdirectory name as input argument. When trying anyway, a first bug pops up:

(Above on Windows but similar on Linux)
That is due to a type on scripts/gui/private/__file-filter__.m

Fixing that and trying again, the next bug pops up:

due to not checking for empty retval before indexing it.

When all this has been fixed uigetfile can also use directory names of path names as input arg. I'll attach a cset as soon as I have the bug number.

Unlike Matlab, whose docs mention that directory names should end with a filesep, I didn't bother to check for that in the patch. If no trailing filesep is present uigetfile displays the parent dir with the lowest dir (to the right of the rightmost filesep) highlighted (if present) or nothing highlighted if no match is found.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38280:  bug48828_uigetfile.cset added by philipnienhuis (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 22 Aug 2016 09:16:08 PM UTCphilipnienhuisStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 19 Aug 2016 03:04:23 PM UTCphilipnienhuisAttached File-=>Added bug48828_uigetfile.cset, #38280
      StatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1