bugGNU Octave - Bugs: bug #48816, Dicom package - dicominfo...

 
 

bug #48816: Dicom package - dicominfo incorectly parses multiframe DICOM

Submitted by:  None
Submitted on:  Thu 18 Aug 2016 04:14:25 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: John Donoghue <lostbard>
Originator Name: Matthew ClemenceOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 4.0.3
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 23 Feb 2017 04:44:31 PM UTC, comment #4:

Closing as fixed - dicom 0.2.0 has been released

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 01 Feb 2017 06:01:25 PM UTC, comment #3:

Pushed a modified version of patch 52 here:

https://sourceforge.net/p/octave/dicom/ci/1ac52d2e4440a92ec878a311b4a576effc7919eb/

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 19 Aug 2016 03:22:35 PM UTC, comment #2:

Updated with example screen shots using public test data BRAINSAG from nema test sets

ftp://medical.nema.org/medical/Dicom/Multiframe/MR/nemamfmr.imagesAB.tar.bz2

multiframeorig - release 4.0.3 with dicom 0.1.1 windows
multiframefixed - release 4.0.3 deb linux built from source with patched dicom-0.1.1

Also - I am now a registered on site

Matthew

(file #38281, file #38282)

Matthew Clemence <drmclem>
Thu 18 Aug 2016 06:16:29 PM UTC, comment #1:

Adding maintainer of the DICOM package to CC

Carnë Draug <carandraug>
Project Member
Thu 18 Aug 2016 04:14:25 PM UTC, original submission:

Hi

When parsing multiframe with dicominfo the nested sequences do not appear in the final structure. Item_XX labels missing and only
one instance of each sequence item stored.

Tested on Linux and windows, Octave 4.0.3, dicom 0.1.1 released
and also compiled from latest mercurial sources.

Example - philips MR enhanced dicom

There seems to be two issues

1)With the code as written, when using assign on octave_map with a map as the second option, the maps are merged rather than a new sub element created - requires cast to octave value. (is this a bug with octave_map?)

2) The test file used has sequences of undefined length (see Dicom standard http://dicom.nema.org/dicom/2013/output/chtml/part05/sect_7.5.html) but these report an item length of 1 in grassroots dicom. Iterators work ok however.

I have compiled from latest sources on hg and attached my current working versions. I have left the original sequence dumping fucntions (except for octave value cast as above) and added a second for the case when Dicom sequence of undefined length.

the two change sets are
51 - to fix the build errors (hack). Building with gdcm 2.6.4 from source and octave-4.0.3 from source. configure doesn't find the libraries correctly in the final makefile

52 - additional seqdump function for multiframe (with extra logging information)

The test data I used is rather large to attach - but any enhanced dicom with sequences of undefined length should show the problem - I work with Philips data and see this issue there.

happy to discuss, help out and work on this if required and would also like to get a new release out

Matthew

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38281:  multiframetest_orig.jpg added by drmclem (254KiB - image/jpeg)
file #38282:  multiframetest_fixed.JPG added by drmclem (212KiB - image/jpeg)
file #38254:  51-buildfix.patch added by None (2KiB - application/octet-stream - change sets v source forge dicom package)
file #38255:  52-multiframefix.patch added by None (5KiB - application/octet-stream - change sets v source forge dicom package)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by drmclem (Updated the item)
  • -unavailable- added by carandraug (Andy Buckle - maintainer of the DICOM package)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 23 Feb 2017 04:44:31 PM UTClostbardStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 01 Feb 2017 06:01:25 PM UTClostbardStatusNone=>Ready For Test
      Assigned toNone=>lostbard
    Fri 19 Aug 2016 03:22:35 PM UTCdrmclemAttached File-=>Added multiframetest_orig.jpg, #38281
      Attached File-=>Added multiframetest_fixed.JPG, #38282
    Thu 18 Aug 2016 06:16:30 PM UTCcarandraugCarbon-Copy-=>Added -unavailable-
    Thu 18 Aug 2016 04:14:25 PM UTCNoneAttached File-=>Added 51-buildfix.patch, #38254
      Attached File-=>Added 52-multiframefix.patch, #38255

    Back to the top


    Powered by Savane 3.1-cleanup1