bugGNU Octave - Bugs: bug #48724, compilation failure with...

 
 

bug #48724: compilation failure with --without-opengl in opengl_renderer::draw_all_lights

Submitter:  Mike Miller <mtmiller>
Submitted:  Mon 08 Aug 2016 07:16:39 PM UTC
   
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 10 Aug 2016 06:59:08 PM UTC, comment #3: 

Applied your patch, with some minor commit message rewording,

http://hg.savannah.gnu.org/hgweb/octave/rev/553490ffc203

Thanks for the quick fix!

Mike Miller <mtmiller>
Group Member
Wed 10 Aug 2016 04:54:50 PM UTC, comment #2: 

The patch looks reasonable. I actually built with --without-fltk --without-opengl --without-qt when testing. Due to some Qt build changes in progress I'm unable to actually build with those configure options at the moment, but I will report back once that is resolved.

Mike Miller <mtmiller>
Group Member
Tue 09 Aug 2016 12:47:42 PM UTC, comment #1: 

Thank you, Mike, for discovering this error.
Attached is a changeset which fixes this compile error and eliminates the warning. However, compilation still fails for me with --without-opengl with the following linker errors:


libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::SliderControl'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::Object'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ButtonControl::metaObject() const'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ListBoxControl'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ToggleTool'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ButtonControl::qt_metacast(char const*)'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::TextEdit'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::TextEdit::returnPressed()'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::PopupMenuControl'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ObjectProxy::sendPrint(QString const&, QString const&)'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::MouseModeActionGroup::modeChanged(QtHandles::MouseMode)'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::Object::metaObject() const'
libgui/.libs/liboctgui.so: undefined reference to `typeinfo for QtHandles::ContextMenu'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::Object::qt_metacast(char const*)'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::EditControl'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::TextEdit::staticMetaObject'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ObjectProxy'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ButtonControl'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::Menu'
libgui/.libs/liboctgui.so: undefined reference to `gluPickMatrix'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ToolBar'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::Object::qt_metacall(QMetaObject::Call, int, void**)'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::TextEdit::editingFinished()'
libgui/.libs/liboctgui.so: undefined reference to `typeinfo for QtHandles::ButtonControl'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::FigureWindow::staticMetaObject'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ObjectProxy::sendUpdate(int)'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::Backend'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::Backend::createObject(double)'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ObjectProxy::sendFinalize()'
libgui/.libs/liboctgui.so: undefined reference to `typeinfo for QtHandles::ButtonGroup'
libgui/.libs/liboctgui.so: undefined reference to `typeinfo for QtHandles::Object'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::FigureWindow'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ButtonGroup'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ButtonControl::qt_metacall(QMetaObject::Call, int, void**)'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ObjectFactory'
libgui/.libs/liboctgui.so: undefined reference to `vtable for annotation_dialog'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::Figure::staticMetaObject'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::ContextMenu'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::PushTool'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::Figure'
libgui/.libs/liboctgui.so: undefined reference to `typeinfo for QtHandles::Figure'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::MouseModeActionGroup::staticMetaObject'
libgui/.libs/liboctgui.so: undefined reference to `QtHandles::ObjectProxy::sendRedraw()'
libgui/.libs/liboctgui.so: undefined reference to `vtable for QtHandles::MouseModeActionGroup'
collect2: error: ld returned 1 exit status


I do not know where these should be fixed. Does the GUI need OpenGL to build successfully?

(file #38155)

Markus Mützel <mmuetzel>
Group administrator
Mon 08 Aug 2016 07:16:39 PM UTC, original submission:  

Build with --without-opengl fails with


../libinterp/corefcn/gl-render.cc: In member function ‘void opengl_renderer::draw_all_lights(const base_properties&, std::__cxx11::list<graphics_object>&)’:
../libinterp/corefcn/gl-render.cc:1665:35: error: ‘GL_LIGHT0’ was not declared in this scope
                   current_light = GL_LIGHT0 + num_lights;
                                   ^~~~~~~~~
../libinterp/corefcn/gl-render.cc: At global scope:
../libinterp/corefcn/gl-render.cc:591:1: warning: ‘int get_maxlights()’ defined but not used [-Wunused-function]
 get_maxlights (void)
 ^~~~~~~~~~~~~


This was introduced with http://hg.savannah.gnu.org/hgweb/octave/rev/20b225a3ebf8. Adding mmuetzel to cc.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by mtmiller (Submitted the item)
  • -email is unavailable- added by mtmiller
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-08-10 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2016-08-10 mtmiller StatusNone Patch Submitted
    2016-08-09 mmuetzel Attached File- Added bug48724_without_opengl.patch, #38155
    2016-08-08 mtmiller Carbon-Copy- Added mmuetzel

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code