GNU Astronomy Utilities - Bugs: bug #48692, Replace TABs with spaces
You are not allowed to post comments on this tracker with your current authentication level.
bug #48692: Replace TABs with spaces
Submitter: | Vladimir Markelov <vvm> | ||
Submitted: | Wed 03 Aug 2016 07:57:09 PM UTC | ||
Category: | All Gnuastro | Severity: | 3 - Normal |
Item Group: | Source code | Status: | Fixed |
Privacy: | Public | Assigned to: | makhlaghi |
Open/Closed: | Closed |
Thu 04 Aug 2016 11:07:09 AM UTC, comment #1: |
Mohammad Akhlaghi <makhlaghi>![]() ![]() |
Wed 03 Aug 2016 07:57:09 PM UTC, original submission:
Imgcrop is an old application and its source contains mix of spaces and TAB characters. Need to beautify the code and eliminate all TABs |
Vladimir Markelov <vvm> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-08-04 | makhlaghi | Category | Crop | ![]() |
All Gnuastro |
Status | None | ![]() |
Fixed | ||
Assigned to | None | ![]() |
makhlaghi | ||
Open/Closed | Open | ![]() |
Closed |
Thank you very much for highlighting this issue! Since the no TABs convention wasn't adopted from the exact start of Gnuastro, some of the older files and functions (and even code pieces that are repeated a lot) actually used TABs for indentation. For those who use Emacs, the '.dir-locals.el' file will be loaded and will not allow the use of TABs for indentation on new code.
This problem was haunting me for a very long time (ever since the no-TABs convention was adopted). I always knew that there is probably code that still uses TABs for indentation, but I would always have more important things to do. So now, I thought of putting the necessary hour or two to go through all the '.c' and '.h' files in 'lib/' and 'src/' and making the correction. It was finally completed and all the changes have been pushed to master.
Thanks again Vladimir for bringing up this issue, and also thanks to Mosè for writing the '.dir-locals.el' file so Emacs users don't have to worry about this issue any more.