bugGNU Astronomy Utilities - Bugs: bug #48650, Double assing value to the same...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48650: Double assing value to the same variable instead of two different variables

Submitter:  Vladimir Markelov <vvm>
Submitted:  Thu 28 Jul 2016 03:48:24 AM UTC
   
 
Category:  ConvertType Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Source code
Status:  Fixed Privacy:  Public
Assigned to:  vvm Open/Closed:  Closed

Discussion

Thu 28 Jul 2016 07:50:29 AM UTC, comment #2: 

Very nice attention at such detail, thank you.

The branch is now merged with master and pushed to the main repo.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Thu 28 Jul 2016 04:05:51 AM UTC, comment #1: 

if you agree that it was bug, please apply the patch from:
https://github.co ... nvertt-assign-min

Patch:
https://github.co ... ba2e4341fb703e32e

Vladimir Markelov <vvm>
Thu 28 Jul 2016 03:48:24 AM UTC, original submission:  

src/convertt/convertt.c

Comment says 'Change the minimum and maximum if desired...' but the code block looks:
if(p->fluxlow!=p->fluxhigh)
    {
      if(p->flminbyte) max=p->fluxlow;
      if(p->fhmaxbyte) max=p->fluxhigh;
}

It seems the first assignment should be:
if(p->flminbyte) min = p->fluxlow;

Vladimir Markelov <vvm>

 

Attached Files

This item currently has no attached files.

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by vvm (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    History

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-28 makhlaghi StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2016-07-28 vvm StatusNone In Progress

    Back to the top

    Powered by Savane 3.16.
    Corresponding source code