bugGNU Astronomy Utilities - Bugs: bug #48642, Buffer to copy string in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48642: Buffer to copy string in setuprename is too small

Submitted by:  Vladimir Markelov <vvm>
Submitted on:  Wed 27 Jul 2016 02:24:15 AM UTC  
 
Category: FitsSeverity: 3 - Normal
Item Group: Source codeStatus: Fixed
Privacy: PublicAssigned to: Vladimir Markelov <vvm>
Open/Closed: Closed

Wed 27 Jul 2016 12:42:47 PM UTC, comment #2:

Thanks, the fix has been merged with master and pushed to the main repo.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Wed 27 Jul 2016 02:30:24 AM UTC, comment #1:

Please see a patch for the issue.
Branch:
https://github.com/VladimirMarkelov/gnuastro-vvm/commits/memory-fix-header-ui
Commit:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/6c6c6ddec4c8e765a6dcb9a5a916f06df03ec587

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Wed 27 Jul 2016 02:24:15 AM UTC, original submission:

Off-by-one error. No space for ending '\0':

c=malloc(strlen(tmp->v));
if(c==NULL) error(EXIT_FAILURE, errno, "space for c in setuprename");
strcpy(c, tmp->v);

Vladimir Markelov <vvm>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by makhlaghi (Posted a comment)
  • -unavailable- added by vvm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 27 Jul 2016 12:42:47 PM UTCmakhlaghiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Wed 27 Jul 2016 02:30:24 AM UTCvvmStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1