bugGNU nano - Bugs: bug #48629, doing a <Left> after coming...

 
 

bug #48629: doing a <Left> after coming from a long line, redraws the current line unnecessarily

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Mon 25 Jul 2016 04:25:53 PM UTC  
 
Severity: 2 - MinorStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 01 Aug 2016 06:06:41 PM UTC, comment #2:

Fixed in git, c9e9964.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 26 Jul 2016 08:49:36 AM UTC, comment #1:

See bug #48627 for a first patch, covering <Left>, <Right>, <Home>, <End>, <Up> and <Down>.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 25 Jul 2016 04:25:53 PM UTC, original submission:

Apply the diagnostic patch from bug #48627. Then create a file with two lines, a long one (that scrolls horizontally) and a short one (that doesn't). Then run src/nano on that file, type <End> on the long line, then move the cursor with <Up> or <Down> to the short line. Type <Left> -- the line is redrawn, even though there is nothing to show or hide, nothing changed.

Expected behavior: when a line does not need horizontal scrolling or unscrolling, it should not be redrawn.

(The problem in do_left() is that it looks at the placewewant, which might be beyond the length of the line and beyond the screen. It should instead look at the actual position of the cursor before it is moved left.)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Aug 2016 10:52:28 AM UTCbensOpen/ClosedOpen=>Closed
    Mon 01 Aug 2016 06:06:41 PM UTCbensStatusIn Progress=>Fixed
    Tue 26 Jul 2016 08:49:36 AM UTCbensStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1