bugGNU Octave - Bugs: bug #48618, Image package: Warnings when...

 
 

bug #48618: Image package: Warnings when installing ver 2.5.1. in dev branch

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Sun 24 Jul 2016 07:39:04 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 07 Dec 2016 04:39:49 AM UTC, comment #20:

Building image package ver 2.6.1 with dev branch does not
produce any warning.

Closing as fixed.

Avinoam Kalma <avinoam>
Project Member
Wed 17 Aug 2016 10:08:49 PM UTC, comment #19:

Do you have another version of Octave installed on windows anywhere? Is this with "pkg install" or with "make all" ? Did you upgrade your clone of the image package first and rerun "./bootstrap"?

Here's the weird lines:

CXX should have been defined to a c++ compiler that supports C++11. With that version of g++, that could mean that CXX would have the -std=c+=11 flags included but it does not. Also, note the line "found /usr/bin/g++". But both the Makefile in the image package, and pkg in Octave set the CXX env variable, so it shouldn't be finding anything because it wouldn't be looking for anything in the first place.

Carnë Draug <carandraug>
Project Member
Wed 17 Aug 2016 06:34:27 PM UTC, comment #18:

Checking on Win-7, I got the warnings again...
config.log attached.

(file #38243)

Avinoam Kalma <avinoam>
Project Member
Tue 16 Aug 2016 07:15:05 PM UTC, comment #17:

I did not check on windows, will do it soon, I then I close this report.

Avinoam Kalma <avinoam>
Project Member
Tue 16 Aug 2016 12:55:26 PM UTC, comment #16:

I'm unsure why it "make install" now works fine for you, I didn't change anything that should have made a difference for that. Does it also work on windows? Can this report be closed?

Carnë Draug <carandraug>
Project Member
Tue 16 Aug 2016 04:58:03 AM UTC, comment #15:

Using your last changes, "make all" and "make install" work fine, without any warnings at all. Thanks!

Avinoam Kalma <avinoam>
Project Member
Tue 16 Aug 2016 12:05:31 AM UTC, comment #14:

Thanks. I changed some things on the maintainers Makefile so "make all" should now work. Please update your clone then try "make clean && ./bootstrap && make all". This should now build all the oct files.

However, I didn't actually change anything in the files that will get installed so unless you changed something else on the system, it should still warn and there is still something to be fixed. I just don't know yet.

Please confirm if "make all" works correctly now. If not please reattach the new config.log. If yes, try "make install". If it still gives warnings, do the following changes:

  1. in the Makefile at the root of the image package, look for 'pkg ("install", "${RELEASE_TARBALL}")' and change it for 'pkg ("install", "-verbose", "${RELEASE_TARBALL}")'
  2. in the file '/usr/local/share/octave/4.1.0+/m/pkg/private/install.m (or the equivalent in your Octave installation), look for this lines (around line 286):

and comment the lines. If you do this, then after you run "make install", there will be a a directory with a random name like "/tmp/oct-XXXXX". Attach the src/config.log inside that directory.

Carnë Draug <carandraug>
Project Member
Mon 15 Aug 2016 07:53:24 PM UTC, comment #13:

Attached src/config.log. I did not understand it :-(

(file #38220)

Avinoam Kalma <avinoam>
Project Member
Mon 15 Aug 2016 06:54:12 PM UTC, comment #12:

Run "make clean && make all". Attach the file src/config.log (and take a look at it, it will show the exact code that it tried to use to check presence of octave::math::namespace).

Carnë Draug <carandraug>
Project Member
Mon 15 Aug 2016 06:33:16 PM UTC, comment #11:

I have uninstalled Octave and reinstalled it, but I get the
same results. I am using gcc 4.9.3.

Any idea?

Avinoam Kalma <avinoam>
Project Member
Mon 15 Aug 2016 12:38:59 AM UTC, comment #10:

See the following lines:

It's failing to find octave::math::min for some reason which is why it defaults to use xmin. I think you have an older version of Octave installed which comes first in the path. If it was using Octave 4.1, the line about C++11 features should come up as "none needed" because Octave 4.1 already requires c++11. Instead it is adding the "-std=gnu++11" flag.

Is "/usr/local/bin/octave" really the Octave version of Octave with hg id 5e27d8d4e3c1 ?

This is what I get:

Carnë Draug <carandraug>
Project Member
Sun 14 Aug 2016 06:57:50 PM UTC, comment #9:

I get on Linux (Ubuntu), usin Octave with hg_id = 5e27d8d4e3c1

and I still get warnings with imreconstruct.

with

Avinoam Kalma <avinoam>
Project Member
Thu 11 Aug 2016 03:53:09 AM UTC, comment #8:

The tarball looks right to me. I don't have windows so you're kind of on your debugging this.

Try to run "make all" instead of "make dist". Do you still get a warning? If so, inspect the config.log (it will be in the src directory) for the configure check that failed. It will show you the exact commands that were run and the file that tried to compile.

Carnë Draug <carandraug>
Project Member
Mon 08 Aug 2016 08:54:15 PM UTC, comment #7:

I am attaching the image package which I build using "make dist".
I have checked the package on win-7 on and Windows-10.
Which other details can help?

(file #38151)

Avinoam Kalma <avinoam>
Project Member
Mon 08 Aug 2016 01:21:48 PM UTC, comment #6:

I don't see that. Can you give details to reproduce it?

Carnë Draug <carandraug>
Project Member
Mon 08 Aug 2016 06:53:07 AM UTC, comment #5:

Checking image ver 2.5.1 after the corrections, with changeset 1723063e65f3, I still get warnings from imreconstruct.cc.
_bilateral_.cc and _spatial_filtering_.cc have been fixed.

Avinoam Kalma <avinoam>
Project Member
Tue 02 Aug 2016 04:41:08 AM UTC, comment #4:

This time fixed properly I think http://hg.code.sf.net/p/octave/image/rev/672b4b8dd371

I'm using

for the compilation test which I'm not 100% sure is the right thing. CXXFLAGS does not have the -I flags and ALL_CXXFLAGS seems to bring too much stuff.

Would be nice if anyone confirms this is the right thing or if I'm overlooking some setup.

Carnë Draug <carandraug>
Project Member
Mon 01 Aug 2016 10:14:09 PM UTC, comment #3:

So the later works when running configure from src manually, but not when using pkg install.

Carnë Draug <carandraug>
Project Member
Mon 01 Aug 2016 09:26:43 PM UTC, comment #2:

I have pushed

Carnë Draug <carandraug>
Project Member
Mon 25 Jul 2016 11:00:14 AM UTC, comment #1:

I don't want the image package to be dependent on the unreleased version of Octave.

This means that removing the warning implis a configure check to find whether octave::math:log exists and use xlog2 if not.

Carnë Draug <carandraug>
Project Member
Sun 24 Jul 2016 07:39:04 PM UTC, original submission:

When installing Image package ver 2.5.1. (not released yet) in dev branch, I get:

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38243:  config.log added by avinoam (38KiB - application/octet-stream)
file #38220:  config.log added by avinoam (25KiB - application/octet-stream)
file #38151:  image-2.5.1.tar.gz added by avinoam (349KiB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 14 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 07 Dec 2016 04:39:49 AM UTCavinoamStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Wed 17 Aug 2016 06:34:27 PM UTCavinoamAttached File-=>Added config.log, #38243
    Mon 15 Aug 2016 07:53:24 PM UTCavinoamAttached File-=>Added config.log, #38220
    Mon 08 Aug 2016 08:54:15 PM UTCavinoamAttached File-=>Added image-2.5.1.tar.gz, #38151
    Mon 08 Aug 2016 06:53:07 AM UTCavinoamOpen/ClosedClosed=>Open
    Mon 08 Aug 2016 06:53:06 AM UTCavinoamStatusFixed=>In Progress
    Tue 02 Aug 2016 04:41:08 AM UTCcarandraugStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Mon 01 Aug 2016 10:14:09 PM UTCcarandraugStatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Mon 01 Aug 2016 09:26:43 PM UTCcarandraugItem GroupInaccurate Result=>Other
      StatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1