GNU Astronomy Utilities - Bugs: bug #48603, The function sanitycheck inside...
You are not allowed to post comments on this tracker with your current authentication level.
bug #48603: The function sanitycheck inside ui.c will fail always if matrixname is not NULL
Submitter: | Vladimir Markelov <vvm> | ||
Submitted: | Sat 23 Jul 2016 04:01:37 PM UTC | ||
Category: | Warp | Severity: | 2 - Minor |
Item Group: | Output not reasonable | Status: | Fixed |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed |
Mon 25 Jul 2016 12:42:08 AM UTC, comment #5: |
Mohammad Akhlaghi <makhlaghi>![]() |
Mon 25 Jul 2016 12:19:18 AM UTC, comment #4: Mohammad, if you don't want to clutter your local repository with other people's branches, in the case of GitHub you can get a patch file for a given commit (or set of commits) by appending ".patch" to the URL. For example, for the commit https://github.com/VladimirMarkelov/gnuastro-vvm/commit/70e7da4d214696d0c827ce0733088791e96b0c77 the corresponding patch file is at https://github.com/VladimirMarkelov/gnuastro-vvm/commit/70e7da4d214696d0c827ce0733088791e96b0c77.patch There is also the ".diff" file, but probably the patch is more useful. |
Mosè Giordano <giordano>![]() |
Sat 23 Jul 2016 04:55:12 PM UTC, comment #3: (This reply is similar for bug #48453, bug #48516 and bug #48603)
Thanks a lot for these very accurate fixes! They certainly required a high-level of attention to detail. All three have now been merged with master and pushed to the main repository. After syncing your repository you can delete the branches in your online repository (so my next fetch from your fork will also remove the branches from my personal repository ;-)).
I would just be most grateful if future commits could apply these notes to make the Gnuastro version controlled history more uniform:
I also had a comment about the patches. Now that you have made a fork or Gnuastro, they might not be necessary for you any more, but I am just noting this for others who might read this.
If the patches are sent to us with Git's format-patch tool, you can directly send us commits (including your identification, date and a message):
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#Public-Project-over-Email
This will make your work fully registered in the version controlled history. The raw patches do not contain thi us information and it will thus be very hard for us to acknowledge your great contributions in the AUTHORS file and/or the PDF manual where all contributors arelisted. |
Mohammad Akhlaghi <makhlaghi>![]() |
Sat 23 Jul 2016 04:01:37 PM UTC, comment #2: This item has been reassigned from the project GNU Astronomy Utilities support tracker to your tracker. The original report is still available at support #109075 Following are the information included in the original report: [field #0] Item ID: 109075 Please,see my patch attached |
Mohammad Akhlaghi <makhlaghi>![]() |
Sun 10 Jul 2016 06:59:18 PM UTC, comment #1: Please, see a patch at my repository.
Branch: https://github.com/VladimirMarkelov/gnuastro-vvm/tree/sr-109075-imagewarp
The commit: https://github.com/VladimirMarkelov/gnuastro-vvm/commit/70e7da4d214696d0c827ce0733088791e96b0c77
|
Vladimir Markelov <vvm>![]() |
Sat 23 Jul 2016 04:01:37 PM UTC, original submission:
The part of condition after checking p->up.matrixname is always true. But, according to error text it should fail only if the matrix is not square or any of its side does not equal 2 or 3.
Please,see my patch attached |
Vladimir Markelov <vvm>![]() |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-07-23 | makhlaghi | Category | None | ![]() |
Warp |
Item Group | None | ![]() |
Output not reasonable | ||
Status | None | ![]() |
Fixed | ||
Open/Closed | Open | ![]() |
Closed | ||
2016-07-23 | makhlaghi | Reassign item | GNU Astronomy Utilities, sr #109075 | ![]() |
GNU Astronomy Utilities, bug #48603 |
Thanks for the very interesting suggestion Mose! I will certainly try it out next time.