bugGNU Octave - Bugs: bug #48556, Tests in publish.tst display plots...

 
 

bug #48556: Tests in publish.tst display plots when run with 'make check'

Submitted by:  Rik <rik5>
Submitted on:  Mon 18 Jul 2016 10:47:12 PM UTC  
 
Category: Configuration and Build SystemSeverity: 5 - Blocker
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Kai Torben Ohlhus <siko1056>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 08 Aug 2016 01:23:23 AM UTC, comment #8:

This bug has been fixed by jwe by making figures invisible before running the tests for publish (http://hg.savannah.gnu.org/hgweb/octave/rev/8971508e21c8). Closing report.

Rik <rik5>
Project Administrator
Sat 30 Jul 2016 08:12:56 AM UTC, comment #7:

I would not like the tests to become demos. Another possibility was to remove all plotting commands from the test scripts and call the tests via

This should disable any graphics for the tests but tests most of publish.

Unfortunately, I can first work on this in two weeks... If you had no time, make them demos and I'll work on this beginning of August.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Fri 29 Jul 2016 01:28:53 PM UTC, comment #6:

Hmm. OK, I could try to turn these into demos, but then they really need to go inside publish.m itself instead of in a separate ".tst" file. That might be tricky though, because these tests depend on external files.

Or we could skip them if we don't have OSMesa.

Or we could add an option to allow tests to generate visible figures (disabled by default).

Not sure what's best or easiest.

John W. Eaton <jwe>
Project Administrator
Fri 29 Jul 2016 10:17:10 AM UTC, comment #5:

I now get 2 failed with

!!!!! test failed
_osmesa_print_: support for offscreen rendering with OSMesa was unavailable or disabled when Octave was built

Doug Stewart <dastew>
Thu 28 Jul 2016 08:54:45 PM UTC, comment #4:

Bad auto complete in comment #3: ... get closed after saving [the plot].

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Thu 28 Jul 2016 08:50:15 PM UTC, comment #3:

@Rik: Yes this way publish in MATLAB works, there also the plots pop up and get closed Adresse saving.

And thanks for your fix jwe, this is better than just checking für the graphics environment to avoid hard errors.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Thu 28 Jul 2016 08:40:09 PM UTC, comment #2:

I checked in the following changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/8971508e21c8

This avoids the problem for me. Closing report.

John W. Eaton <jwe>
Project Administrator
Tue 19 Jul 2016 03:59:14 PM UTC, comment #1:

Is it expected that publish will display figures as it works? Is that what Matlab does?

If not, I suppose we could do something like save and restore the root figure property 'defaultfigurevisible' so that all figures it generates are hidden by default? But even that won't always prevent it from displaying figures since it's possible for a function or script to override the default.

Either way, for our tests, we should probably either set the default visibility or convert the tests into demos.

This needs to be fixed before the release. The test suite should not draw figures.

John W. Eaton <jwe>
Project Administrator
Mon 18 Jul 2016 10:47:12 PM UTC, original submission:

Running 'make check' from a shell runs all of Octave's BIST tests, but it shouldn't cause plots to appear and disappear on the screen.

I'm sure this is related to the recent incorporation of publish.m into core Octave from Octave-Forge.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dastew (Posted a comment)
  • -unavailable- added by siko1056 (Posted a comment)
  • -unavailable- added by jwe (adding Kai to the notification list)
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 08 Aug 2016 01:23:23 AM UTCrik5StatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sat 30 Jul 2016 08:15:01 AM UTCsiko1056Open/ClosedClosed=>Open
    Sat 30 Jul 2016 08:14:43 AM UTCsiko1056Item GroupNone=>Incorrect Result
      StatusFixed=>In Progress
      Assigned toNone=>siko1056
    Thu 28 Jul 2016 08:40:09 PM UTCjweStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Fri 22 Jul 2016 04:35:56 PM UTCjweCarbon-Copy-=>Added siko1056
    Tue 19 Jul 2016 05:06:07 PM UTCmtmillerSeverity2 - Minor=>5 - Blocker

    Back to the top


    Powered by Savane 3.1-cleanup1