bugGNU Octave - Bugs: bug #48552, isonormals should point towards...

 
 

bug #48552: isonormals should point towards lower values for Matlab compatibility

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Mon 18 Jul 2016 11:50:49 AM UTC  
 
Category: PlottingSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 Jul 2016 11:39:59 PM UTC, comment #2:

I pushed your patch for isonormals here (http://hg.savannah.gnu.org/hgweb/octave/rev/ba8a9d2934c7). I also added a comment to the NEWS file since some people may notice this in their code.

Rik <rik5>
Project Administrator
Mon 18 Jul 2016 12:01:05 PM UTC, comment #1:

Attached is the patch that cahnges the docstring, adds some tests (including for this compatibility issue) and adds some minor cosmatic changes.

I also converted the example in the docstring to a demo. It might be interesting to also find this on Andreas' page.

(file #37932)

Markus Mützel <mmuetzel>
Project Member
Mon 18 Jul 2016 11:50:49 AM UTC, original submission:

As can be seen in [1], the vertex normals as calculated with "isonormals" point in the opposite direction as compared to Matlab.
See also:

I will attach a patch with a change to get the same result in Matlab and in Octave as soon as I get a bug number.

[1] http://josoansi.de/octave_plot_compare/compare_plot_demos_04.html#light_08

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37932:  isonormals.patch added by mmuetzel (11KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mmuetzel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 Jul 2016 11:39:59 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 18 Jul 2016 12:01:05 PM UTCmmuetzelAttached File-=>Added isonormals.patch, #37932

    Back to the top


    Powered by Savane 3.1-cleanup1